Spectre.Console repo fixes #248
Conversation
mthalman
requested review from
baronfel and
MichaelSimons
and removed request for
MichaelSimons
| @@ -1,86 +0,0 @@ | ||
| -/* | ||
| -Ported from: https://rosettacode.org/wiki/Mandelbrot_set#C.23 | ||
| -Licensed under GNU Free Documentation License 1.2 |
There was a problem hiding this comment.
Will this actually address the license issue? The license will still exist in this patch.
There was a problem hiding this comment.
But it wouldn't exist in the VMR.
There was a problem hiding this comment.
It would (see here) - these patches get applied dynamically to the inner build of source-build-externals. They are treated differently than the source-build patches.
| @@ -0,0 +1,103 @@ | |||
| From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 | |||
There was a problem hiding this comment.
I think Patrik was going to remove this from the repo tonight, so if we stall a day we may just be able to update the submodule and remove this patch + remove my PackageReference-commenting patch.
There was a problem hiding this comment.
Oh, is a new release planned soon then?
There was a problem hiding this comment.
Not a new release, but there have only been 9 commits to main since the 0.48.0 release was tagged (at time of writing), and the majority of those have been build-infra related, so I could see an argument for us bumping the submodule to the commits from today that introduced the PackageReference Condition and removed the incompatibly-licensed example file.
There was a problem hiding this comment.
Our preference is to only pin to a release commit to ensure quality as established by the repo maintainer.
|
I've removed the Mandelbrot deletion patch since the path still includes a reference to the license. There doesn't appear to be a way to define a patch that doesn't include the file's content. So we'll need to address this via VMR cloaking. |
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.Build"> | ||
| <Version>15.7.179</Version> |
There was a problem hiding this comment.
Would it make sense to encapsulate this version in versions.props? It would make updating easier and follow the arcade patterns.
There was a problem hiding this comment.
I'll log a separate issue for that since it should be done for all the other relevant external repos as well.
There was a problem hiding this comment.
Fixes dotnet/source-build#3817
Because spectre.console has a global.json file targeting 8.0.100, it fails to build now that the tooling for the SBE has been updated to use .NET 9 SDK.
This is fixed by using the existing
UpdateGlobalJsonVersionstarget. The problem is that it makes use of an MSBuild task that doesn't exist in the repo. So I've added it back along with implementation which will build the tasks project.