Implement auto-restarting on rude edit or no-effect change #48752
+227
−110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements auto-restarting behavior when a rude edit or a no-effect change is detected. Key changes include:
- Updated tests (in ApplyDeltaTests.cs, RuntimeProcessLauncherTests.cs, and CompilationHandlerTests.cs) to validate auto-restart on both rude edits and changes with no effect.
- Adjustments to the hot reload logic in CompilationHandler.cs and HotReloadDotNetWatcher.cs to incorporate a new GlobalOptions parameter and to handle project auto-restart determination.
- Addition of the IsAutoRestartEnabled extension method in ProjectGraphNodeExtensions.cs to support the new auto-restart configuration.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/dotnet-watch.Tests/HotReload/RuntimeProcessLauncherTests.cs | Removed an outdated process output check to align with the new restart behavior. |
| test/dotnet-watch.Tests/HotReload/CompilationHandlerTests.cs | Updated CompilationHandler instantiation with an extra GlobalOptions parameter. |
| test/dotnet-watch.Tests/HotReload/ApplyDeltaTests.cs | Added new theory tests for auto-restart on rude and no-effect edits and updated assertion messages accordingly. |
| test/TestAssets/TestProjects/WatchHotReloadApp/Program.cs | Updated the class C placeholder to include a comment for later source modifications. |
| src/BuiltInTools/dotnet-watch/Utilities/ProjectGraphNodeExtensions.cs | Added the IsAutoRestartEnabled extension to check the HotReloadAutoRestart property. |
| src/BuiltInTools/dotnet-watch/HotReloadDotNetWatcher.cs | Modified CompilationHandler instantiation to provide Context.Options to the new parameter. |
| src/BuiltInTools/dotnet-watch/HotReload/CompilationHandler.cs | Updated constructor signatures, diagnostic reporting, and process restart logic to support auto-restart. |
3 tasks
DustinCampbell
approved these changes
May 5, 2025
| @@ -45,6 +45,9 @@ public static string GetAssemblyName(this ProjectGraphNode projectNode) | |||
| public static IEnumerable<string> GetCapabilities(this ProjectGraphNode projectNode) | |||
| => projectNode.ProjectInstance.GetItems("ProjectCapability").Select(item => item.EvaluatedInclude); | |||
|
|
|||
| public static bool IsAutoRestartEnabled(this ProjectGraphNode projectNode) | |||
| => bool.TryParse(projectNode.ProjectInstance.GetPropertyValue("HotReloadAutoRestart"), out var result) && result; | |||
There was a problem hiding this comment.
Should this constant be defined somewhere?
There was a problem hiding this comment.
This is kind of that definition. I can make it a const field, but it's ever going to be used here.
Co-authored-by: Dustin Campbell <dustin@teamcampbell.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using APIs added in dotnet/roslyn#78220, implements auto-restart of a project that have
HotReloadAutoRestartproperty set, or any project if--non-interactiveis passed on command line.dotnet-watch automatically terminates associated processes, rebuilds and re-launches the project whenever a rude edit or no-effect change is detected.