Skip to content

[StaticWebAssets] Ensure HtmlAssetPlaceholders are executed before ServiceWorker #48623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2025
Merged

[StaticWebAssets] Ensure HtmlAssetPlaceholders are executed before ServiceWorker #48623

merged 1 commit into from
Apr 22, 2025

Conversation

maraf
Copy link
Member

@maraf maraf commented Apr 22, 2025 •
edited
Loading

The ResolveHtmlAssetPlaceholdersBuildStaticWebAssets needs to run before ResolveBuildServiceWorkerStaticWebAssetsConfiguration so that service worker targets get correct HTML StaticWebAssets.

Related to #46233

@maraf maraf added the Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch label Apr 22, 2025
@maraf maraf self-assigned this Apr 22, 2025
@Copilot Copilot AI review requested due to automatic review settings April 22, 2025 13:02
Copilot
Copilot AI reviewed Apr 22, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • src/StaticWebAssetsSdk/Targets/Microsoft.NET.Sdk.StaticWebAssets.HtmlAssetPlaceholders.targets: Language not supported

@ghost ghost added the untriaged Request triage from a team member label Apr 22, 2025
@maraf maraf requested a review from a team April 22, 2025 13:02
@maraf maraf added this to the 10.0.1xx milestone Apr 22, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Thanks for your PR, @@maraf.
To learn about the PR process and branching schedule of this repo, please take a look at the SDK PR Guide.

@maraf maraf removed the untriaged Request triage from a team member label Apr 22, 2025
@maraf maraf changed the title [StaticWebAssets] Ensure HtmlAssetPlaceholders are execute before ServiceWorker [StaticWebAssets] Ensure HtmlAssetPlaceholders are executed before ServiceWorker Apr 22, 2025
@maraf maraf enabled auto-merge (squash) April 22, 2025 13:49
@maraf maraf merged commit 429f584 into main Apr 22, 2025
43 checks passed
@maraf maraf deleted the maraf/SwaHapFixSw branch April 22, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@javiercn javiercn javiercn approved these changes

Assignees

@maraf maraf

Labels
Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch
Projects
None yet
Milestone
10.0.1xx
Development

Successfully merging this pull request may close these issues.
2 participants
@maraf @javiercn