Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vs-solutionpersistence: 1.0.28 -> 1.0.52 #47328

Merged
merged 3 commits into from
Mar 8, 2025
Merged

vs-solutionpersistence: 1.0.28 -> 1.0.52 #47328

merged 3 commits into from
Mar 8, 2025

Conversation

edvilme
Copy link
Member

@edvilme edvilme commented Mar 6, 2025

Fixes #47297

@Copilot Copilot bot review requested due to automatic review settings March 6, 2025 19:34
Copilot
Copilot AI reviewed Mar 6, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-NetSDK untriaged Request triage from a team member labels Mar 6, 2025
@build-analysis build-analysis bot mentioned this pull request Mar 6, 2025
Open
@edvilme edvilme requested a review from a team March 6, 2025 22:20
@kasperk81 kasperk81 mentioned this pull request Mar 7, 2025
Merged
@mthalman
Copy link
Member

mthalman commented Mar 7, 2025

@edvilme - It wasn't made known in dotnet/source-build-externals#454 that this was for 9.0. That PR will need to be backported to the 9.0 branch.

@surayya-MS surayya-MS mentioned this pull request Mar 7, 2025
Merged
@edvilme
Copy link
Member Author

edvilme commented Mar 7, 2025

Re targeting to 9.0.3xx

@edvilme edvilme changed the base branch from release/9.0.2xx to release/9.0.3xx March 7, 2025 19:34
@edvilme
Copy link
Member Author

edvilme commented Mar 7, 2025

@edvilme - It wasn't made known in dotnet/source-build-externals#454 that this was for 9.0. That PR will need to be backported to the 9.0 branch.

Backport ready at dotnet/source-build-externals#456

@mthalman
Copy link
Member

mthalman commented Mar 7, 2025

Dependency flow for 9.0.1xx is here: #47364.

This was referenced Mar 7, 2025
Open
Open
Open
@edvilme edvilme enabled auto-merge (squash) March 7, 2025 23:38
@edvilme edvilme disabled auto-merge March 7, 2025 23:47
@kasperk81
Copy link
Contributor

@akoeplinger should this pr revert 595df90?

@akoeplinger
Copy link
Member

@kasperk81 I think we actually need the msbuild bump first since the test broke in that dependency flow so it seems to be using the vs-solutionpersistence from there.

@dotnet-maestro @akoeplinger
[release/9.0.1xx] Update dependencies from dotnet/source-build-extern…
ae75038 
…als (dotnet#47364)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
(cherry picked from commit c35d72a)
@kasperk81
Copy link
Contributor

msbuild update is #47385

@akoeplinger akoeplinger merged commit 5a93642 into dotnet:release/9.0.3xx Mar 8, 2025
30 checks passed
akoeplinger pushed a commit that referenced this pull request Mar 9, 2025
@edvilme @akoeplinger
vs-solutionpersistence: 1.0.28 -> 1.0.52 (#47328)
fe3d728 
Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
(cherry picked from commit 5a93642)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@MiYanni MiYanni MiYanni approved these changes

Assignees
No one assigned
Labels
Area-NetSDK untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@edvilme @mthalman @kasperk81 @akoeplinger @MiYanni