Disable Flaky GivenDotnetTest Tests #46924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please see dotnet#46923 for more information.
ghost
added
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
test/dotnet-test.Tests/GivenDotnetTestBuildsAndRunsTests.cs:121
- [nitpick] There is an inconsistency in how the Skip parameter is formatted (extra space around '='). Consider removing the space to match the other instances (i.e., use Skip="
GivenDotnetTestFailures #46923").
[Theory(Skip = "https://github.com/dotnet/sdk/issues/46923")]
test/dotnet-test.Tests/GivenDotnetTestBuildsAndRunsTests.cs:16
- Disabling tests via the Skip parameter will reduce test coverage; please ensure there is a plan or comment to track re-enabling these tests once the underlying issue is resolved.
[Theory(Skip= "https://github.com/dotnet/sdk/issues/46923")]
Evangelink
approved these changes
Feb 18, 2025
nagilson
added a commit
to nagilson/sdk
that referenced
this pull request
Feb 21, 2025
In this PR a few days ago I disabled some similar tests: dotnet#46924 It turns out that even more of them are failing about 80%+ of the time after some recent changes to these tests. See here: dotnet#47003 (review) here: dotnet#47004 (review) here: https://github.com/dotnet/sdk/pull/47004/checks?check_run_id=37586911841 here: dotnet#47014 etc. I've already made an issue to track this: dotnet#46923 So I'll keep using that one. The maintainer has been notified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see #46923 for more information.