Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded SHA256 usage #46289

Merged

Conversation

GrabYourPitchforks
Copy link
Member

The SameContent method takes two strings, computes their digests, and compares the digests. Since the strings are already in memory, we may as well bypass the digest computation and simply compare the string contents directly.

Copy link
Contributor

Thanks for your PR, @GrabYourPitchforks.
To learn about the PR process and branching schedule of this repo, please take a look at the SDK PR Guide.

@GrabYourPitchforks GrabYourPitchforks merged commit 2c54f08 into dotnet:main Jan 28, 2025
35 of 38 checks passed
@GrabYourPitchforks GrabYourPitchforks deleted the simplify_samecontents branch January 28, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch Area-Infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants