Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dotnet-watch] Simplify file watching #44603

Merged
merged 2 commits into from
Nov 10, 2024
Merged

[dotnet-watch] Simplify file watching #44603

merged 2 commits into from
Nov 10, 2024

Conversation

tmat
Copy link
Member

@tmat tmat commented Nov 2, 2024 •
edited
Loading

Refactoring and simplification.

Renames:

  • IFileSystemWatcher to IDirectoryWatcher,
  • DotnetFileWatcher to EventBasedDirectoryWatcher,
  • PollingFileWatcher to PollingDirectoryWatcher

Deletes HotReloadFileSetWatcher - this type provided file change batching (observed file changes during 50 millisecond intervals were batched) and translation of raw file change events to ChangedFile instances. The functionality is now integrated in Hot Reload loop of HotReloadDotNetWatcher

@tmat tmat requested a review from a team as a code owner November 2, 2024 17:25
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch untriaged Request triage from a team member labels Nov 2, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Thanks for your PR, @tmat.
To learn about the PR process and branching schedule of this repo, please take a look at the SDK PR Guide.

This was referenced Nov 2, 2024
Open
Open
@tmat tmat force-pushed the FileWatcher branch 2 times, most recently from d59fa95 to a6c6ff3 Compare November 6, 2024 19:36
@tmat tmat enabled auto-merge (squash) November 9, 2024 21:59
@tmat tmat changed the title Simplify file watching [dotnet-watch] Simplify file watching Nov 9, 2024
@tmat tmat merged commit b60190c into dotnet:release/9.0.2xx Nov 10, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-allen-msft phil-allen-msft phil-allen-msft approved these changes

Assignees
No one assigned
Labels
Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmat @phil-allen-msft