-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create project templates target to 10.0 #44349
Conversation
Looks like we need to merge the #43015 code flow first to address the error message.
|
@v-wuzhai the other PR is now in so we can fix the merge conflicts and start getting this one unblocked. |
@@ -38,7 +38,7 @@ | |||
"generator": "regexMatch", | |||
"datatype": "bool", | |||
"parameters": { | |||
"pattern": "^(net5.0|net6.0|net7.0|net8.0|net9.0)$*", | |||
"pattern": "^(net5.0|net6.0|net7.0|net8.0|net9.0|net10.0)$*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"pattern": "^(net5.0|net6.0|net7.0|net8.0|net9.0|net10.0)$*", | |
"pattern": "^net([5-9]|[1-9]\\d{1,})\\.0$*", |
as done in
sdk/test/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishANetCoreAppForTelemetry.cs
Line 53 in bd5b082
"\"Crossgen2PackVersion\":\"([5-9]|[1-9]\\d{1,})\\..+\""); |
ci checks passed @marcpopMSFT |
...t-new.Tests/Approvals/DotnetNewHelpTests.CanShowHelpForTemplate_MatchOnLanguage.verified.txt
Show resolved
Hide resolved
Should we remove the 9.0 templates (like we removed 8.0 from the 9.0 branch)? We can do those changes in a separate PR. Still not sure why the net9.0 version is missing from the test run as it'll be needed eventually. Is that because we're using a VS image that doesn't have 9 yet maybe? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving assuming we'll do the other changes I outlined in a separate PR.
@marcpopMSFT I will submit a separate PR to address the issues you mentioned. |
@marcpopMSFT I have created an issue to track the missing net9.0 templates: #44736. We will update our test environment once the templates are available. |
No description provided.