Add pass 2 specifications for sdk projects #43694
Open
+13
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid building projects in pass 1 that require assets from multiple verticals
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
mmitche
commented
Sep 25, 2024
| @@ -6,4 +6,11 @@ | |||
| <ProjectToBuild Include="$(RepoRoot)src/VirtualMonoRepo/InitializeVMR.proj" BuildInParallel="false" /> | |||
| </ItemGroup> | |||
|
|
|||
| <!-- Do not populate ProjectToBuild except when we are explicitly in a non-default pass (pass 1, DotNetBuildPass == '') | |||
| so that we get the arcade defaults for what to build. --> | |||
| <ItemGroup Condition="'$(DotNetBuildPass)' != ''"> | |||
There was a problem hiding this comment.
After @jkoritzinsky's change propagates to the VMR, this should be no longer necessary
jkoritzinsky
approved these changes
Sep 25, 2024
This was referenced Sep 25, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid building projects in pass 1 that require assets from multiple verticals