Improve logging from agent - #43672
Merged
Merged
Conversation
ghost
added
Area-AspNetCore
Contributor
|
Thanks for your PR, @tmat. |
tmat
commented
Sep 24, 2024
| public HotReloadAgent(Action<string> log) | ||
| public HotReloadAgent(NamedPipeClientStream pipeClient, Action<string> stdOutLog) | ||
| { | ||
| var metadataUpdater = Type.GetType("System.Reflection.Metadata.MetadataUpdater, System.Runtime.Loader", throwOnError: false); |
Member
Author
There was a problem hiding this comment.
Moved to GetUpdaterMethods.
tmat
commented
Sep 24, 2024
| } | ||
| } | ||
|
|
||
| internal sealed class UpdateHandlerActions |
Member
Author
There was a problem hiding this comment.
Moved to MetadataUpdateHandlerInvoker.
tmat
commented
Sep 24, 2024
| /// <summary> | ||
| /// Internal for testing. | ||
| /// </summary> | ||
| internal RegisteredActions GetMetadataUpdateHandlerActions(IEnumerable<Type> handlerTypes) |
Member
Author
There was a problem hiding this comment.
Just moved and refactored.
Member
Author
|
@phil-allen-msft PTAL |
This was referenced Sep 25, 2024
phil-allen-msft
approved these changes
Sep 27, 2024
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the agent only logs to std out, which is redirected by apps (e.g. asp.net). It also doesn't consider output verbosity of dotnet-watch.
Instead of logging via stdout we now send log messages back to the dotnet-watch pipe, so that dotnet-watch can report them in the same way it does other messages.
Also refactors and cleans up the agent implementation.
Implements #43323.