Remove internet sources from auditSources section #42740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
| @@ -35,15 +35,40 @@ public class RemoveInternetSourcesFromNuGetConfig : Task | |||
| /// </summary> | |||
There was a problem hiding this comment.
Since you are adding functionality, please consider adding #nullable enable to this file.
There was a problem hiding this comment.
Fixed with fadcef8
MichaelSimons
approved these changes
Aug 14, 2024
mthalman
approved these changes
Aug 14, 2024
|
Bunch of nullable-related warnings promoted to errors. I did not see them in local build or full verification build. Checking... |
MichaelSimons
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: dotnet/source-build#4553
Extends the task to cover
auditSourcessection, and enables future extensions.Removes the temporary patch that was added with #42706