Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LoongArch64] Add linux-loongarch64 RID for Net90AppHostRids and Net90RuntimePackRids. #41515

Closed
wants to merge 1 commit into from

Conversation

LuckyXu-HF
Copy link

Add linux-loongarch64 RID for Net90AppHostRids and Net90RuntimePackRids.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Jun 11, 2024
@LuckyXu-HF
Copy link
Author

Hi @shushanhf @am11 @akoeplinger ,could you please review this PR ? Thanks.

@am11
Copy link
Member

am11 commented Jun 11, 2024

@LuckyXu-HF, these are already inherited from:

<Net60AppHostRids Include="
@(Net50AppHostRids);
osx-arm64;
linux-s390x;
linux-loongarch64;
" />
<Net60RuntimePackRids Include="
@(Net50RuntimePackRids);
osx-arm64;
linux-s390x;
linux-loongarch64;
" />
(6->7->8->9)

@LuckyXu-HF
Copy link
Author

LuckyXu-HF commented Jun 11, 2024

@LuckyXu-HF, these are already inherited from:

<Net60AppHostRids Include="
@(Net50AppHostRids);
osx-arm64;
linux-s390x;
linux-loongarch64;
" />
<Net60RuntimePackRids Include="
@(Net50RuntimePackRids);
osx-arm64;
linux-s390x;
linux-loongarch64;
" />

(6->7->8->9)

Hi @am11 , thank you very much and apologize for my careless. I will close this PR.
BTW, do you have a plan for commit the dotnet/runtime#102628 further ?
I believe some architectures that currently do not support NativeAOT will benefit from it. The LA64-NativeAOT feature is currently under development, and I think @shushanhf will commit it soon.

Now the build of clr within the main branch for LA64 will hit the relate error, it's because the NativeAot is not properly isolating well. And your PR#102628 will help to solve this issue a lot.

xuliangyu@loongson-pc:/data_loongson/xuliangyu/runtime$ ./build.sh clr -rc release  
  正在确定要还原的项目…
  工具“coverlet.console”(版本“6.0.0”)已还原。可用的命令: coverlet
  工具“dotnet-reportgenerator-globaltool”(版本“5.3.0”)已还原。可用的命令: reportgenerator
  工具“microsoft.dotnet.xharness.cli”(版本“9.0.0-prerelease.24270.4”)已还原。可用的命令: xharness
  工具“microsoft.visualstudio.slngen.tool”(版本“11.1.0”)已还原。可用的命令: slngen
  
  还原成功。
  所有项目均是最新的,无法还原。
  正在确定要还原的项目…
/data_loongson/xuliangyu/runtime/.dotnet/sdk/9.0.100-preview.3.24204.13/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(90,5): error NETSDK1204: 当前平台“linux-loongarch64”不支持提前编译。 [/data_loongson/xuliangyu/runtime/Build.proj]
  无可执行操作。指定的项目均不包含可还原的包。

生成失败。

/data_loongson/xuliangyu/runtime/.dotnet/sdk/9.0.100-preview.3.24204.13/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(90,5): error NETSDK1204: 当前平台“linux-loongarch64”不支持提前编译。 [/data_loongson/xuliangyu/runtime/Build.proj]
    0 个警告
    1 个错误

已用时间 00:00:14.20
Build failed with exit code 1. Check errors above.

@LuckyXu-HF LuckyXu-HF closed this Jun 11, 2024
@LuckyXu-HF LuckyXu-HF deleted the main-LA64 branch June 11, 2024 07:28
@am11
Copy link
Member

am11 commented Jun 11, 2024

I was moving my apartment, and having some time off GitHub. 😅

@LuckyXu-HF
Copy link
Author

I was moving my apartment, and having some time off GitHub. 😅

Wishing you a pleasant move and have a nice day. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants