Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We don't need this 🙃 #35594

Merged
merged 1 commit into from
Sep 22, 2023
Merged

We don't need this 🙃 #35594

merged 1 commit into from
Sep 22, 2023

Conversation

MiYanni
Copy link
Member

@MiYanni MiYanni commented Sep 20, 2023

Summary

When looking over some CLI code, I kept noticing this. Since this doesn't do anything, I removed this. In some codebases, this can help differentiate between 2 different members. Here, I did not find a situation that requires this. Since this appears grey in VS, let's just remove this.

@MiYanni MiYanni requested a review from a team September 20, 2023 21:54
@MiYanni MiYanni requested review from a team and vijayrkn as code owners September 20, 2023 21:54
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Sep 20, 2023
Copy link
Member

@Forgind Forgind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice name 😁

@MiYanni MiYanni merged commit f70581f into dotnet:main Sep 22, 2023
16 checks passed
@MiYanni MiYanni deleted the ThisIsNotUseful branch September 22, 2023 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants