Skip to content

[release/8.0.1xx] Add Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100 as a dependency #35569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

dkurepa
Copy link
Member

@dkurepa dkurepa commented Sep 20, 2023

Add Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100 as a dependency and use its version for microsoft.net.workload.emscripten.current, since it stabilizes. Fixes: https://dev.azure.com/dnceng/internal/_build/results?buildId=2268247&view=logs&j=6781b346-0bd1-5062-714a-0158c8df1d42&t=28240f7a-11a7-53df-bdd9-fb54c991f1ba&l=589

…ependency and use its version for microsoft.net.workload.emscripten.current
@dkurepa dkurepa requested a review from marcpopMSFT September 20, 2023 10:18
@ghost ghost added Area-CodeFlow untriaged Request triage from a team member labels Sep 20, 2023
@dkurepa dkurepa changed the title Add Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100 as a dependency [release/8.0.1xx] Add Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100 as a dependency Sep 20, 2023
@marcpopMSFT
Copy link
Member

@dkurepa you have a few PRs targeting 8.0.1xx, are you prepping them for GA?

Copy link
Member

@lewing lewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is good to go now

@lewing
Copy link
Member

lewing commented Oct 21, 2023

I opened #36340 with actual values now that there is a build

@marcpopMSFT
Copy link
Member

@lewing is this needed for GA? CC @mmitche

@mmitche
Copy link
Member

mmitche commented Oct 25, 2023

Appears to have already been integrated. Thanks @dkurepa for putting this up.

@mmitche mmitche closed this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-CodeFlow untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants