Fix regeneration of files when asset cache changes. #3441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both the deps.json and runtimeconfig.json files remain unchanged when an incremental build takes place that changes a property that would invalidate the assets cache. For a property like `SelfContained`, this might mean the files are no longer valid for the incremental build's output. Fixes dotnet/cli#11956.
nguerrera
reviewed
Jul 20, 2019
nguerrera
approved these changes
Jul 20, 2019
dsplaisted
pushed a commit
to dsplaisted/sdk
that referenced
this pull request
Feb 19, 2020
….4 (dotnet#3441) - Microsoft.DotNet.Cli.Runtime - 3.1.100-preview3.19552.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both the deps.json and runtimeconfig.json files remain unchanged when an
incremental build takes place that changes a property that would invalidate the
assets cache.
For a property like
SelfContained, this might mean the files are no longervalid for the incremental build's output.
Fixes dotnet/cli#11956.