Containers: fix handling of ContainerBaseImage without a registry. #32876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These images are meant to be pulled from Docker Hub.
The wrong hostname was used for the registry ('registry-1.docker.io' vs 'docker.io').
The parsing of names like 'ubuntu/dotnet-runtime' lead to 'ubuntu' being treated as the
registry.
This also enables using 'docker.io' as an alias to the Docker registry.
And adds the required 'library/' prefixing for short-names (like 'ubuntu' to 'library/ubuntu').
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
ghost
added
the
|
I've added a commit that addresses dotnet/sdk-container-builds#443 too. |
tmds
commented
May 30, 2023
src/Containers/Microsoft.NET.Build.Containers/Resources/Strings.Designer.cs
Show resolved
Hide resolved
baronfel
approved these changes
May 30, 2023
|
I'm testing this locally on baronfel/sdk-container-demo and running into a runtime crash when trying to target the My first guess - I'm running that repo on the public preview4 bits - did something change in the Regex generator and since the SDK might be using a more recent runtime there's now a mismatch? I'm trying to validate the end-to-end user experience before I merge here. Looks like a similar issue to dotnet/runtime#85913 (comment)? |
|
Yes, I believe the issue is on my side. Using the SDK's However, working against Docker's registry exposed another gap - docker seems to prefer/send OCI Image manifests, not 'docker' content types. Here's what we send However, those all return a 404. When I request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These images are meant to be pulled from Docker Hub.
The wrong hostname was used for the registry ('registry-1.docker.io' vs 'docker.io').
The parsing of names like 'ubuntu/dotnet-runtime' lead to 'ubuntu' being treated as the registry.
This also enables using 'docker.io' as an alias to the Docker registry.
And adds the required 'library/' prefixing for short-names (like 'ubuntu' to 'library/ubuntu').
@baronfel ptal.
Fixes dotnet/sdk-container-builds#445
Fixes dotnet/sdk-container-builds#444
Fixes dotnet/sdk-container-builds#443