Skip to content

Next helix test move #25057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 3, 2022
Merged

Next helix test move #25057

merged 4 commits into from
May 3, 2022

Conversation

marcpopMSFT
Copy link
Member

Reduce the helix move to a single test group to limit the impact in the build and see if the main set of changes can get in.

…he build and see if the main set of changes can get in.
@ghost ghost added the Area-Infrastructure label Apr 25, 2022
@marcpopMSFT
Copy link
Member Author

@dsplaisted @gkulin I was seeing workload manifest mismatches (between mono and emsdk) in this PR. Digging through the log files, one of Grace's manifest update tests ran just before a failure regarding a mismatched manifest (though our log files didn't capture enough info for me to confirm that it was updating the manifests of the dotnet used in the later test). Once I disabled Grace's tests, the PR passed.
https://github.com/dotnet/sdk/runs/6218772748
71683fb

I'm inclined to file a bug to have Grace review those 3 tests I disabled to figure out why they are impacting other tests and merge this PR (and keep going with the helix migrations). Thoughts?

From the ubuntu log file:

Running /mnt/vss/_work/1/s/artifacts/bin/redist/Release/dotnet/dotnet workload install --verbosity:minimal wasm-tools
Process ID: 22477
Running /mnt/vss/_work/1/s/artifacts/bin/redist/Release/dotnet/dotnet msbuild /t:Restore /mnt/vss/_work/1/s/artifacts/tmp/Release/It_builds_wit---198ADF14/HelloWorld.csproj
Process ID: 22506
Running /mnt/vss/_work/1/s/artifacts/bin/redist/Release/dotnet/dotnet msbuild /t:Restore /mnt/vss/_work/1/s/artifacts/tmp/Release/_GivenDotnetR---C87024F7/TestAppEchoDotnetRoot.csproj
Process ID: 22533
Running /mnt/vss/_work/1/s/artifacts/bin/redist/Release/dotnet/dotnet msbuild /t:Restore /mnt/vss/_work/1/s/artifacts/tmp/Release/_GivenDotnetR---C87024F7/TestAppEchoDotnetRoot.csproj
Process ID: 22556
�[31;1m    Microsoft.DotNet.Cli.Run.Tests.GivenDotnetRootEnv.ItShouldSetDotnetRootToDirectoryOfMuxer(targetFramework: "net5.0") [FAIL]
�[m�[37m      Expected command to pass but it did not.
�[m�[37m      File Name: /mnt/vss/_work/1/s/artifacts/bin/redist/Release/dotnet/dotnet
�[m�[37m      Arguments: msbuild /t:Restore /mnt/vss/_work/1/s/artifacts/tmp/Release/_GivenDotnetR---C87024F7/TestAppEchoDotnetRoot.csproj
�[m�[37m      Exit Code: 1
�[m�[37m      StdOut:
�[m�[37m      Microsoft (R) Build Engine version 17.3.0-preview-22227-03+a1fa15d13 for .NET
�[m�[37m      Copyright (C) Microsoft Corporation. All rights reserved.
�[m�[37m      
�[m�[37m      /mnt/vss/_work/1/s/artifacts/tmp/Release/_GivenDotnetR---C87024F7/TestAppEchoDotnetRoot.csproj : error MSB4242: SDK Resolver Failure: "The SDK resolver "Microsoft.DotNet.MSBuildWorkloadSdkResolver" failed while attempting to resolve the SDK "Microsoft.NET.Sdk". Exception: "Microsoft.NET.Sdk.WorkloadManifestReader.WorkloadManifestCompositionException: Workload manifest dependency 'Microsoft.NET.Workload.Emscripten' version '7.0.0-preview.3.22122.1' is lower than version '7.0.0-preview.4.22215.1' required by manifest 'microsoft.net.workload.mono.toolchain' [/mnt/vss/_work/1/s/artifacts/bin/redist/Release/dotnet/sdk-manifests/7.0.100/microsoft.net.workload.mono.toolchain/WorkloadManifest.json]

@dsplaisted
Copy link
Member

Yes, that sounds right. Probably those tests are modifying state that we didn't expect them to (ie modifying the workloads that are installed in stage 2).

@marcpopMSFT
Copy link
Member Author

I'm going to update the reporoot per Daniel's feedback and add a link to #25175 in the skip comment before merging.

@marcpopMSFT marcpopMSFT merged commit 195b387 into main May 3, 2022
@baronfel baronfel mentioned this pull request May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants