[main] Update dependencies from dotnet/runtime #24195

dotnet-maestro · 2022-03-03T13:26:12Z

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

Subscription: aa69f164-2492-460a-3914-08d8e9750bf8
Build: 20220308.2
Date Produced: March 8, 2022 5:36:53 PM UTC
Commit: 8342a08b8bf0ff2ffb64cd5992e2d60c8d6d63c1
Branch: refs/heads/main

Updates:
- Microsoft.NETCore.App.Runtime.win-x64: from 7.0.0-preview.3.22151.6 to 7.0.0-preview.3.22158.2
- Microsoft.NETCore.Platforms: from 7.0.0-preview.3.22151.6 to 7.0.0-preview.3.22158.2
- Microsoft.NETCore.DotNetHostResolver: from 7.0.0-preview.3.22151.6 to 7.0.0-preview.3.22158.2
- System.Reflection.MetadataLoadContext: from 7.0.0-preview.3.22151.6 to 7.0.0-preview.3.22158.2
- System.Text.Encoding.CodePages: from 7.0.0-preview.3.22151.6 to 7.0.0-preview.3.22158.2
- System.Security.Cryptography.ProtectedData: from 7.0.0-preview.3.22151.6 to 7.0.0-preview.3.22158.2
- System.Resources.Extensions: from 7.0.0-preview.3.22151.6 to 7.0.0-preview.3.22158.2
- System.CodeDom: from 7.0.0-preview.3.22151.6 to 7.0.0-preview.3.22158.2
- Microsoft.NET.HostModel: from 7.0.0-preview.3.22151.6 to 7.0.0-preview.3.22158.2
- Microsoft.Extensions.DependencyModel: from 7.0.0-preview.3.22151.6 to 7.0.0-preview.3.22158.2
- Microsoft.NETCore.App.Host.win-x64: from 7.0.0-preview.3.22151.6 to 7.0.0-preview.3.22158.2
- Microsoft.NETCore.App.Ref: from 7.0.0-preview.3.22151.6 to 7.0.0-preview.3.22158.2
- VS.Redist.Common.NetCore.TargetingPack.x64.7.0: from 7.0.0-preview.3.22151.6 to 7.0.0-preview.3.22158.2
- VS.Redist.Common.NetCore.SharedFramework.x64.7.0: from 7.0.0-preview.3.22151.6 to 7.0.0-preview.3.22158.2

…0302.5 Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.NETCore.DotNetHostResolver , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Text.Encoding.CodePages , System.Security.Cryptography.ProtectedData , System.CodeDom , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , VS.Redist.Common.NetCore.TargetingPack.x64.7.0 , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 From Version 7.0.0-preview.3.22151.6 -> To Version 7.0.0-preview.3.22152.5

dotnet-maestro · 2022-03-03T13:31:17Z

Notification for subscribed users from https://github.com/dotnet/runtime:

@dnr-codeflow

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

This pull request contains changes from your source repo (https://github.com/dotnet/runtime) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
For more details, please read the Arcade Darc documentation

pranavkm · 2022-03-03T20:28:45Z

CSC(0,0): error CS8032: (NETCORE_ENGINEERING_TELEMETRY=Build) An instance of analyzer System.Text.RegularExpressions.Generator.RegexGenerator cannot be created from /Users/runner/work/1/s/.packages/microsoft.netcore.app.ref/7.0.0-preview.3.22152.5/analyzers/dotnet/cs/System.Text.RegularExpressions.Generator.dll : Could not load file or assembly 'Microsoft.CodeAnalysis, Version=4.2.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35'. The system cannot find the file specified.

FYI @jkoritzinsky

jkoritzinsky · 2022-03-03T20:42:05Z

We just updated the version of Roslyn that we build the source generators that will ship in .NET 7 build against. We did this to pick up new Roslyn APIs and bug fixes. Can the SDK update which Roslyn toolset it builds against?

danmoseley · 2022-03-03T21:43:51Z

Perhaps that is happening in #24188?

jkoritzinsky · 2022-03-03T21:47:26Z

That PR looks like it's actually downgrading Roslyn for some odd reason...

pranavkm · 2022-03-04T00:02:12Z

FYI @jaredpar because of the fun discussion from today.

v-wuzhai · 2022-03-04T05:48:01Z

/azp run

azure-pipelines · 2022-03-04T05:48:12Z

Azure Pipelines successfully started running 1 pipeline(s).

…0304.1 Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.NETCore.DotNetHostResolver , System.Reflection.MetadataLoadContext , System.Text.Encoding.CodePages , System.Security.Cryptography.ProtectedData , System.Resources.Extensions , System.CodeDom , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , VS.Redist.Common.NetCore.TargetingPack.x64.7.0 , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 From Version 7.0.0-preview.3.22151.6 -> To Version 7.0.0-preview.3.22154.1

marcpopMSFT · 2022-03-04T21:48:12Z

/azp run

azure-pipelines · 2022-03-04T21:48:23Z

Azure Pipelines successfully started running 1 pipeline(s).

danmoseley · 2022-03-05T03:48:41Z

❌[Log] CSC(0,0): error CS8032: An instance of analyzer System.Text.RegularExpressions.Generator.RegexGenerator cannot be created from D:\a_work\1\s.packages\microsoft.netcore.app.ref\7.0.0-preview.3.22154.1\analyzers\dotnet\cs\System.Text.RegularExpressions.Generator.dll : Could not load file or assembly 'Microsoft.CodeAnalysis, Version=4.2.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35'. The system cannot find the file specified..

…0304.8 Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.NETCore.DotNetHostResolver , System.Reflection.MetadataLoadContext , System.Text.Encoding.CodePages , System.Security.Cryptography.ProtectedData , System.Resources.Extensions , System.CodeDom , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , VS.Redist.Common.NetCore.TargetingPack.x64.7.0 , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 From Version 7.0.0-preview.3.22151.6 -> To Version 7.0.0-preview.3.22154.8

…0305.4 Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.NETCore.DotNetHostResolver , System.Reflection.MetadataLoadContext , System.Text.Encoding.CodePages , System.Security.Cryptography.ProtectedData , System.Resources.Extensions , System.CodeDom , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , VS.Redist.Common.NetCore.TargetingPack.x64.7.0 , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 From Version 7.0.0-preview.3.22151.6 -> To Version 7.0.0-preview.3.22155.4

danmoseley · 2022-03-07T05:19:30Z

@dotnet/domestic-cat @stephentoub could you throw any light on this error above? What might have changed here?

jkoritzinsky · 2022-03-07T06:39:41Z

My comment above has the explanation: #24195 (comment)

…0307.1 Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.NETCore.DotNetHostResolver , System.Reflection.MetadataLoadContext , System.Text.Encoding.CodePages , System.Security.Cryptography.ProtectedData , System.Resources.Extensions , System.CodeDom , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , VS.Redist.Common.NetCore.TargetingPack.x64.7.0 , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 From Version 7.0.0-preview.3.22151.6 -> To Version 7.0.0-preview.3.22157.1

danmoseley · 2022-03-07T13:37:25Z

Ah I see. The last one updated up to 3 days ago. I guess another should go up soon (?)

jeffschwMSFT · 2022-03-07T18:30:12Z

I am taking over helping @danmoseley with this issue. @jaredpar, @jkoritzinsky @pranavkm what is the latest status? Who has the next action? Thanks

jkoritzinsky · 2022-03-07T18:34:49Z

If dotnet/sdk can update the version of Roslyn they reference when building (so the Microsoft.Net.Compilers.Toolset package version) to at least 4.2.0-2.22128.1, then this PR should become green. I know the sdk repo is more intimately affected by the "stage 0" sdk version, so although I think just updating the version of that package that is referenced should work totally fine, I don't know 100% for sure.

jeffschwMSFT · 2022-03-07T19:09:55Z

Thanks @jkoritzinsky. @dotnet/domestic-cat is there someone able to help investigate updating the version of Roslyn?

@jkoritzinsky do we know what about this payload that is leading to this situation? Is it a faster path to revert that work until we resolve these downstream impacts? (Asking especially if this impact is likely to happen in more repos).

jaredpar · 2022-03-07T19:17:25Z

do we know what about this payload that is leading to this situation?

Yes. Roughly what is happening here is that all of our source generators depend on the latest Roslyn API. The Roslyn API is just another NuPkg, that dependency moves forward like any other dependency. This PR is pulling down an SDK from the 6.0.300 flavor, based on the version in the error, which means the generators in it depend on the 4.2.0.0 version of the Roslyn API. The SDK though has pinned the actual compiler used to build which means it did not roll forward to 6.0.300 versions and it has a version of 4.1.0.0 or earlier. Hence when the generators attempt to run in the compiler there is a version mismatch.

This is a danger of pinning compiler toolsets. It's a component that essentially has plugin support. If you move the plugins forward but keep the host backwards eventually you hit a version mismatch.

marcpopMSFT · 2022-03-07T19:48:12Z

@jaredpar, the SDK being pulled down is actually 5 months old at 7.0.100-alpha.1.21478.48. Is updating to the preview 1 SDK sufficient or will we need something even newer?

jaredpar · 2022-03-07T19:53:02Z

Could not load file or assembly 'Microsoft.CodeAnalysis, Version=4.2.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35'. The system cannot find the file specified..

That is the error in the thread and that is a 6.0.300 compiler version. Something is trying to load it during build.

…0308.1 Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.NETCore.DotNetHostResolver , System.Reflection.MetadataLoadContext , System.Text.Encoding.CodePages , System.Security.Cryptography.ProtectedData , System.Resources.Extensions , System.CodeDom , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , VS.Redist.Common.NetCore.TargetingPack.x64.7.0 , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 From Version 7.0.0-preview.3.22151.6 -> To Version 7.0.0-preview.3.22158.1

wtgodbe · 2022-03-08T21:16:13Z

Test failures seem more ordinary now, e.g.

Microsoft.NET.Build.Tests.ReferenceExeTests.ExeProjectCanReferenceTestProject(testTemplateName: \"mstest\")

StdErr:
Project C:\h\w\BC3209FC\t\dotnetSdkTests\clnzv4vx.33x\ExeProjectCan---317DC12F\TestProject\TestProject.csproj cannot be added due to incompatible targeted frameworks between the two projects. Review the project you are trying to add and verify that is compatible with the following targets: net6.0

And:

Microsoft.NET.Build.Tests.WorkloadTests.Given_multi_target_It_should_get_suggested_workload_by_GetRequiredWorkloads_target(mainTfm: \"net6.0\", referencingTfm: \"net6.0\", expected: \"macos\")

Expected collection {"wasm-tools"} to contain "macos".

@dsplaisted @marcpopMSFT who knows about these tests?

danmoseley · 2022-03-08T21:48:05Z

possibly @lewing knows about that.

jeffschwMSFT · 2022-03-09T00:56:38Z

Test failures seem more ordinary now, e.g.

Microsoft.NET.Build.Tests.ReferenceExeTests.ExeProjectCanReferenceTestProject(testTemplateName: "mstest")

StdErr:
Project C:\h\w\BC3209FC\t\dotnetSdkTests\clnzv4vx.33x\ExeProjectCan---317DC12F\TestProject\TestProject.csproj cannot be > added due to incompatible targeted frameworks between the two projects. Review the project you are trying to add and verify that is compatible with the following targets: net6.0

@marcpopMSFT can you help take a look?

Microsoft.NET.Build.Tests.WorkloadTests.Given_multi_target_It_should_get_suggested_workload_by_GetRequiredWorkloads_target(mainTfm: "net6.0", referencingTfm: "net6.0", expected: "macos")

Expected collection {"wasm-tools"} to contain "macos".

@marek-safar and @lewing can you help take a look?

joeloff · 2022-03-09T01:49:19Z

@marcpopMSFT I wonder if this is the known workloads.txt file that's missing again when the stage0 and stage2 SDKs are merged to run tests.

…0308.2 Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.NETCore.DotNetHostResolver , System.Reflection.MetadataLoadContext , System.Text.Encoding.CodePages , System.Security.Cryptography.ProtectedData , System.Resources.Extensions , System.CodeDom , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , VS.Redist.Common.NetCore.TargetingPack.x64.7.0 , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 From Version 7.0.0-preview.3.22151.6 -> To Version 7.0.0-preview.3.22158.2

marcpopMSFT · 2022-03-09T17:17:31Z

@joeloff @wtgodbe That second issue is definitely because of the workloads text file. That's the same behavior we saw when trying to update to 6.0.101 with an empty file. We either need to disable the tests for now or fix the stage0/stage2 merge. I'd probably default to disabling since 7.0 doesn't support maui at the moment so overall workload support is minimal.

marcpopMSFT · 2022-03-09T17:21:23Z

@wtgodbe for ExeProjectCanReferenceTestProject, we should try updating the target framework value in the test to net7.0.

marcpopMSFT · 2022-03-09T17:24:36Z

@javiercn , can you investigate the failure in Publish60Hosted_Works? Looks like it's expecting an rc2 runtime but we updated to the 6.0.0 version.

"_framework/dotnet.6.0.0-rc.2.21452.2.[[hash]].js.gz" with a length of 51, but
"_framework/dotnet.6.0.2.[[hash]].js.gz" has a length of 38.

wtgodbe · 2022-03-09T18:36:30Z

Still seeing a source-build issue:

/__w/1/s/artifacts/source-build/self/package-cache/microsoft.net.compilers.toolset/4.2.0-2.22158.15/tasks/net6.0/Microsoft.CSharp.Core.targets(75,5): error : CompilerServer: fatal error - server reports different hash version than build task - 92730825-cec3-4fc9-a08f-b5b1a2d893c2 [/__w/1/s/artifacts/source-build/self/src/src/Cli/Microsoft.DotNet.InternalAbstractions/Microsoft.DotNet.InternalAbstractions.csproj]

@dagood @MichaelSimons I see dotnet/source-build#1473, is this related? Is there a known fix?

javiercn · 2022-03-09T18:58:18Z

@marcpopMSFT looking at it.

...ebAssembly.Tests/StaticWebAssetsBaselines/Publish60Hosted_Works.Publish.staticwebassets.json

dagood · 2022-03-09T20:20:45Z

/__w/1/s/artifacts/source-build/self/package-cache/microsoft.net.compilers.toolset/4.2.0-2.22158.15/tasks/net6.0/Microsoft.CSharp.Core.targets(75,5): error : CompilerServer: fatal error - server reports different hash version than build task - 92730825-cec3-4fc9-a08f-b5b1a2d893c2 [/__w/1/s/artifacts/source-build/self/src/src/Cli/Microsoft.DotNet.InternalAbstractions/Microsoft.DotNet.InternalAbstractions.csproj]

I see dotnet/source-build#1473, is this related? Is there a known fix?

Should be able to disable shared compilation (compiler server) to stop the machine from finding two versions of the compiler with different hashes: dotnet/source-build#1527. @dotnet/source-build-internal

wtgodbe · 2022-03-09T21:34:00Z

Looks like the SDK enables it by default:

sdk/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.targets

Lines 940 to 942 in 8d1e1e4

    
           <PropertyGroup Condition="'$(UseSharedCompilation)' == ''"> 
        
             <UseSharedCompilation>true</UseSharedCompilation> 
        
           </PropertyGroup>

. Seems like disabling that would be a pretty big change - @dsplaisted @marcpopMSFT is that the direction we want to go?

jkoritzinsky · 2022-03-09T21:48:55Z

That file is included in the produced SDK and is not imported by MSBuild during the build of this repo. I think the property setter should be added in eng/SourceBuild.props as part of the InnerBuildArgs https://github.com/dotnet/sdk/blob/main/eng/SourceBuild.props

jeffschwMSFT · 2022-03-09T23:56:30Z

:) thank you everyone for helping to get this merged!

ghost added the Area-CodeFlow label Mar 3, 2022

dotnet-maestro bot added 2 commits March 5, 2022 13:19

Update global.json

1a4d13e

marcpopMSFT and others added 3 commits March 7, 2022 12:48

Update restore-toolset.sh

2ac6a64

Update restore-toolset.ps1

bc3e2fc

Update Versions.props

6d9dd98

wtgodbe mentioned this pull request Mar 8, 2022

[main] Update dependencies from dotnet/efcore dotnet/runtime dotnet/aspnetcore#40507

Merged

wtgodbe added 3 commits March 8, 2022 11:27

Merge branch 'main' into darc-main-4e4c3a83-79d4-4dbf-a084-18667262c049

5f24844

Update redist.csproj

5b2b048

Update global.json

39fe197

marek-safar and others added 2 commits March 9, 2022 10:28

Merge branch 'main' into darc-main-4e4c3a83-79d4-4dbf-a084-18667262c049

7bb8ead

wtgodbe added 3 commits March 9, 2022 09:40

Update ReferenceExeTests.cs

9c76c20

Update Versions.props

e90f350

Update WorkloadTests.cs

cfc8f5c

Update baselines

bc1ce27

TanayParikh reviewed Mar 9, 2022

View reviewed changes

...ebAssembly.Tests/StaticWebAssetsBaselines/Publish60Hosted_Works.Publish.staticwebassets.json Show resolved Hide resolved

wtgodbe added 2 commits March 9, 2022 14:31

Update SourceBuild.props

d15aedf

Merge branch 'main' into darc-main-4e4c3a83-79d4-4dbf-a084-18667262c049

b8723c0

marcpopMSFT approved these changes Mar 9, 2022

View reviewed changes

TanayParikh merged commit b69e8f5 into main Mar 9, 2022

TanayParikh deleted the darc-main-4e4c3a83-79d4-4dbf-a084-18667262c049 branch March 9, 2022 23:47

[main] Update dependencies from dotnet/runtime #24195

[main] Update dependencies from dotnet/runtime #24195

Uh oh!

Conversation

dotnet-maestro bot commented Mar 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

From https://github.com/dotnet/runtime

Uh oh!

dotnet-maestro bot commented Mar 3, 2022

Notification for subscribed users from https://github.com/dotnet/runtime:

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

Uh oh!

pranavkm commented Mar 3, 2022

Uh oh!

jkoritzinsky commented Mar 3, 2022

Uh oh!

danmoseley commented Mar 3, 2022

Uh oh!

jkoritzinsky commented Mar 3, 2022

Uh oh!

pranavkm commented Mar 4, 2022

Uh oh!

v-wuzhai commented Mar 4, 2022

Uh oh!

azure-pipelines bot commented Mar 4, 2022

Uh oh!

marcpopMSFT commented Mar 4, 2022

Uh oh!

azure-pipelines bot commented Mar 4, 2022

Uh oh!

danmoseley commented Mar 5, 2022

Uh oh!

danmoseley commented Mar 7, 2022

Uh oh!

jkoritzinsky commented Mar 7, 2022

Uh oh!

danmoseley commented Mar 7, 2022

Uh oh!

jeffschwMSFT commented Mar 7, 2022

Uh oh!

jkoritzinsky commented Mar 7, 2022

Uh oh!

jeffschwMSFT commented Mar 7, 2022

Uh oh!

jaredpar commented Mar 7, 2022

Uh oh!

marcpopMSFT commented Mar 7, 2022

Uh oh!

jaredpar commented Mar 7, 2022

Uh oh!

wtgodbe commented Mar 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

danmoseley commented Mar 8, 2022

Uh oh!

jeffschwMSFT commented Mar 9, 2022

Uh oh!

joeloff commented Mar 9, 2022

Uh oh!

marcpopMSFT commented Mar 9, 2022

Uh oh!

marcpopMSFT commented Mar 9, 2022

Uh oh!

marcpopMSFT commented Mar 9, 2022

Uh oh!

wtgodbe commented Mar 9, 2022

Uh oh!

javiercn commented Mar 9, 2022

Uh oh!

Uh oh!

dagood commented Mar 9, 2022

Uh oh!

wtgodbe commented Mar 9, 2022

Uh oh!

jkoritzinsky commented Mar 9, 2022

Uh oh!

jeffschwMSFT commented Mar 9, 2022

Uh oh!

Uh oh!

dotnet-maestro bot commented Mar 3, 2022 •

edited

Loading

wtgodbe commented Mar 8, 2022 •

edited

Loading