Skip to content

Commit a805a27

Browse files
committed
Feedback
1 parent fc3b5f2 commit a805a27

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

documentation/general/ExecutingCustomerCode.md

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@ Windows Sandbox permits safely running any operation in a controlled, isolated e
2828

2929
Conveniently, however, it is relatively easy to copy files from your host computer into Sandbox, and as noted earlier, it is a secure, isolated environment, so it is an excellent choice if it is viable.
3030

31+
Before executing customer code in Windows Sandbox, make sure to [disable networking](https://learn.microsoft.com/windows/security/application-security/application-isolation/windows-sandbox/windows-sandbox-configure-using-wsb-file#networking).
32+
3133
### Create Your Own Solution
3234

3335
Depending on how well you understand the customer's scenario, you may or may not understand ahead of time the most likely problem, but if it's possible to create your own solution that reproduces the issue the customer alluded to in their report, and you understand all the steps it took to create that solution, that is a safe method for obtaining a project to test and debug. Note that this is only a secure method if you understand all steps involved in creating the test project. "Copy project file provided by customer to disk and build it" does not count as a well-understood pair of steps.
@@ -42,10 +44,6 @@ That said, this is a secure means for executing a customer's scenario, and it wo
4244

4345
For Microsoft employees, [DevTestLab](https://ms.portal.azure.com/#browse/Microsoft.Compute%2FVirtualMachines) can help you create VMs.
4446

45-
#### Docker
46-
47-
As a corollary to using VMs to sequester the customer's scenario away from sensitive parts of your machine, containers (notably Docker containers) are intended to create a small, self-contained environment in which to operate. They're cheaper to create than full VMs, though with more stringent resource limitations and some missing or altered functionality, they may not work for some scenarios. Even so, if they work, they can be a safer and cheaper option than creating a VM. Make sure to follow general best practices such as running in rootless mode if possible and avoiding signing in using your credentials.
48-
4947
### Read Code
5048

5149
If none of the above methods work, it may be viable to read all customer code carefully to ensure that no part of it is risky or malicious. Many IDEs such as Visual Studio automatically run design-time builds when code is open. As a result, even just opening a malicious code base in Visual Studio can lead to exploits. Prefer an IDE that does not run design-time builds. Some examples include:
@@ -71,7 +69,7 @@ If you discover that a customer provided a malicious project or solution, there
7169
1. Most importantly, do not keep any vestige of the repro on your machine. Do not follow their steps.
7270
2. Add a note to the issue that it was malicious. Include this information in the title if possible.
7371
3. Delete the contents of the repro steps. (On GitHub, it can still be found by looking at your edit.)
74-
4. Report the infraction using https://aka.ms/reportitnow
72+
4. Report the infraction using https://aka.ms/reportitnow (This step is only available to Microsoft employees.)
7573
5. Report your finding to your manager and your security team.
7674
6. Depending on the severity of the issue, consider banning the user from GitHub.
7775

0 commit comments

Comments
 (0)