Dispose HttpClient in WorkloadManifestUpdater (#41489)

dsplaisted · web-flow · commit 8be158631c02 · 2024-06-12T12:32:25.000-04:00
diff --git a/src/Cli/dotnet/commands/dotnet-workload/install/WorkloadManifestUpdater.cs b/src/Cli/dotnet/commands/dotnet-workload/install/WorkloadManifestUpdater.cs
@@ -526,7 +526,8 @@ public IEnumerable<ManifestVersionUpdate> ParseRollbackDefinitionFiles(IEnumerab
 
             if (Uri.TryCreate(rollbackDefinitionFilePath, UriKind.Absolute, out var rollbackUri) && !rollbackUri.IsFile)
             {
-                fileContent = (new HttpClient()).GetStringAsync(rollbackDefinitionFilePath).Result;
+                using HttpClient httpClient = new();
+                fileContent = httpClient.GetStringAsync(rollbackDefinitionFilePath).Result;
             }
             else
             {

Original file line number	Diff line number	Diff line change
`@@ -526,7 +526,8 @@ public IEnumerable<ManifestVersionUpdate> ParseRollbackDefinitionFiles(IEnumerab`
`526`	`526`
`527`	`527`	`if (Uri.TryCreate(rollbackDefinitionFilePath, UriKind.Absolute, out var rollbackUri) && !rollbackUri.IsFile)`
`528`	`528`	`{`
`529`		`- fileContent = (new HttpClient()).GetStringAsync(rollbackDefinitionFilePath).Result;`
	`529`	`+ using HttpClient httpClient = new();`
	`530`	`+ fileContent = httpClient.GetStringAsync(rollbackDefinitionFilePath).Result;`
`530`	`531`	`}`
`531`	`532`	`else`
`532`	`533`	`{`