Add support for SunOS-like platforms

Author: am11

src/Cli/Microsoft.DotNet.Cli.Utils/FileNameSuffixes.cs

@@ -24,17 +24,11 @@ public static PlatformFileNameSuffixes CurrentPlatform
                 {
                     return OSX;
                 }
-                else if (RuntimeInformation.IsOSPlatform(OSPlatform.Linux))
-                {
-                    return Linux;
-                }
-                else if (RuntimeInformation.IsOSPlatform(OSPlatform.Create("FREEBSD")))
-                {
-                    return FreeBSD;
-                }
                 else
                 {
-                    throw new InvalidOperationException("Unknown Platform");
+                    // assume everything else is Unix to avoid modifying this file
+                    // everytime a new platform is introduced in runtime.
+                    return Unix;
                 }
             }
         }
@@ -58,21 +52,19 @@ public static PlatformFileNameSuffixes CurrentPlatform
         public static PlatformFileNameSuffixes OSX { get; } = new PlatformFileNameSuffixes
         {
             DynamicLib = ".dylib",
-            Exe = "",
+            Exe = string.Empty,
             ProgramDatabase = ".pdb",
             StaticLib = ".a"
         };
 
-        public static PlatformFileNameSuffixes Linux { get; } = new PlatformFileNameSuffixes
+        public static PlatformFileNameSuffixes Unix { get; } = new PlatformFileNameSuffixes
         {
             DynamicLib = ".so",
-            Exe = "",
+            Exe = string.Empty,
             ProgramDatabase = ".pdb",
             StaticLib = ".a"
         };
 
-        public static PlatformFileNameSuffixes FreeBSD { get; } = Linux;
-
         public struct PlatformFileNameSuffixes
         {
             public string DynamicLib { get; internal set; }

src/Cli/Microsoft.DotNet.Cli.Utils/RuntimeEnvironment.cs

@@ -13,7 +13,9 @@ internal enum Platform
         Windows = 1,
         Linux = 2,
         Darwin = 3,
-        FreeBSD = 4
+        FreeBSD = 4,
+        illumos = 5,
+        Solaris = 6
     }
 
     internal static class RuntimeEnvironment
@@ -36,15 +38,19 @@ private static string GetOSName()
             switch (GetOSPlatform())
             {
                 case Platform.Windows:
-                    return "Windows";
+                    return nameof(Platform.Windows);
                 case Platform.Linux:
-                    return GetDistroId() ?? "Linux";
+                    return GetDistroId() ?? nameof(Platform.Linux);
                 case Platform.Darwin:
                     return "Mac OS X";
                 case Platform.FreeBSD:
-                    return "FreeBSD";
+                    return nameof(Platform.FreeBSD);
+                case Platform.illumos:
+                    return GetDistroId() ?? nameof(Platform.illumos);
+                case Platform.Solaris:
+                    return nameof(Platform.Solaris);
                 default:
-                    return "Unknown";
+                    return nameof(Platform.Unknown);
             }
         }
 
@@ -55,11 +61,16 @@ private static string GetOSVersion()
                 case Platform.Windows:
                     return Environment.OSVersion.Version.ToString(3);
                 case Platform.Linux:
+                case Platform.illumos:
                     return GetDistroVersionId() ?? string.Empty;
                 case Platform.Darwin:
                     return Environment.OSVersion.Version.ToString(2);
                 case Platform.FreeBSD:
                     return GetFreeBSDVersion() ?? string.Empty;
+                case Platform.Solaris:
+                    // RuntimeInformation.OSDescription example on Solaris 11.3:      SunOS 5.11 11.3
+                    // we only need the major version; 11
+                    return RuntimeInformation.OSDescription.Split(' ')[2].Split('.')[0];
                 default:
                     return string.Empty;
             }
@@ -98,6 +109,19 @@ private static string GetDistroVersionId()
         }
 
         private static DistroInfo LoadDistroInfo()
+        {
+            switch (GetOSPlatform())
+            {
+                case Platform.Linux:
+                    return LoadDistroInfoFromLinux();
+                case Platform.illumos:
+                    return LoadDistroInfoFromIllumos();
+            }
+
+            return null;
+        }
+
+        private static DistroInfo LoadDistroInfoFromLinux()
         {
             DistroInfo result = null;
 
@@ -138,6 +162,36 @@ private static DistroInfo LoadDistroInfo()
             return result;
         }
 
+        private static DistroInfo LoadDistroInfoFromIllumos()
+        {
+            DistroInfo result = null;
+            // examples:
+            //   on OmniOS
+            //       SunOS 5.11 omnios-r151018-95eaa7e
+            //   on OpenIndiana Hipster:
+            //       SunOS 5.11 illumos-63878f749f
+            //   on SmartOS:
+            //       SunOS 5.11 joyent_20200408T231825Z
+            var versionDescription = RuntimeInformation.OSDescription.Split(' ')[2];
+            switch (versionDescription)
+            {
+                case string version when version.StartsWith("omnios"):
+                    result.Id = "OmniOS";
+                    result.VersionId = version.Substring("omnios-r".Length, 2); // e.g. 15
+                    break;
+                case string version when version.StartsWith("joyent"):
+                    result.Id = "SmartOS";
+                    result.VersionId = version.Substring("joyent_".Length, 4); // e.g. 2020
+                    break;
+                case string version when version.StartsWith("illumos"):
+                    result.Id = "OpenIndiana";
+                    // version-less
+                    break;
+            }
+
+            return result;
+        }
+
         // For some distros, we don't want to use the full version from VERSION_ID. One example is
         // Red Hat Enterprise Linux, which includes a minor version in their VERSION_ID but minor
         // versions are backwards compatable.
@@ -179,10 +233,20 @@ private static Platform DetermineOSPlatform()
             {
                 return Platform.Darwin;
             }
-            if (RuntimeInformation.IsOSPlatform(OSPlatform.Create("FREEBSD")))
+#if NETCOREAPP
+            if (RuntimeInformation.IsOSPlatform(OSPlatform.FreeBSD))
             {
                 return Platform.FreeBSD;
             }
+            if (RuntimeInformation.IsOSPlatform(OSPlatform.Create("ILLUMOS")))
+            {
+                return Platform.illumos;
+            }
+            if (RuntimeInformation.IsOSPlatform(OSPlatform.Create("SOLARIS")))
+            {
+                return Platform.Solaris;
+            }
+#endif
 
             return Platform.Unknown;
         }