Commit 25a743b
committed
Prevent restore loop in VS
The `GetReferenceAssemblyPaths` target adds a `PackageReference` to `Microsoft.NETFramework.ReferenceAssemblies` when needed.
In VS, this new package causes VS to nominate a NuGet restore then perform another design-time build.
That second design-time build was previously determining that the `PackageReference` was no longer needed, then removing it. The task's `FullFrameworkReferenceAssemblyPaths` output parameter contains the full path of the reference assembly folder in such a case, which fails the empty-string test.
This change tests whether the output parameter is a reference to the package, and if so allows the `PackageReference` to remain.1 parent 7d7d543 commit 25a743b
File tree
1 file changed
+1
-2
lines changed- src/Tasks/Microsoft.NET.Build.Tasks/targets
1 file changed
+1
-2
lines changedsrc/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets
Lines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
426 | 426 | | |
427 | 427 | | |
428 | 428 | | |
429 | | - | |
430 | 429 | | |
431 | 430 | | |
432 | 431 | | |
433 | 432 | | |
434 | | - | |
| 433 | + | |
435 | 434 | | |
436 | 435 | | |
437 | 436 | | |
| |||
0 commit comments