introduce resources for error strings, update comments

Author: Chet Husk

src/Cli/Microsoft.DotNet.Cli.Utils/Verbosity.cs

@@ -12,3 +12,20 @@ public enum Verbosity
     detailed,
     diagnostic
 }
+
+public static class VerbosityData
+{
+    public static string[] VerbosityNames =
+    [
+        "quiet",
+        "q",
+        "minimal",
+        "m",
+        "normal",
+        "n",
+        "detailed",
+        "d",
+        "diagnostic",
+        "diag"
+    ];
+}

src/Cli/dotnet/CliStrings.resx

@@ -302,7 +302,12 @@
 {1}.</value>
   </data>
   <data name="VerbosityOptionDescription" xml:space="preserve">
-    <value>Set the MSBuild verbosity level. Allowed values are q[uiet], m[inimal], n[ormal], d[etailed], and diag[nostic].</value>
+    <value>Set the MSBuild verbosity level. Allowed values are: {0}.</value>
+    <comment>{0} is a comma-separated list of allowed string values</comment>
+  </data>
+  <data name="VerbosityParserInvalidToken" xml:space="preserve">
+    <value>'{0}' is not a valid value for --verbosity. Allowed values are: {1}.</value>
+    <comment>{0} is the invalid token, {1} is a comma-separated list of allowed string values</comment>
   </data>
   <data name="CmdVersionSuffixDescription" xml:space="preserve">
     <value>Set the value of the $(VersionSuffix) property to use when building the project.</value>

src/Cli/dotnet/CommonOptions.cs

@@ -143,7 +143,7 @@ public static string[] SplitMSBuildValues(string? defaultValue, ArgumentResult a
     public static Option<Verbosity> VerbosityOption(Verbosity defaultVerbosity) =>
         new Option<Verbosity>("--verbosity", "-v")
         {
-            Description = CliStrings.VerbosityOptionDescription,
+            Description = string.Format(CliStrings.VerbosityOptionDescription, string.Join(", ", VerbosityData.VerbosityNames)),
             HelpName = CliStrings.LevelArgumentName,
             DefaultValueFactory = _ => defaultVerbosity,
             CustomParser = static r => ParseVerbosityEnum(r)!.Value
@@ -154,7 +154,7 @@ public static Option<Verbosity> VerbosityOption(Verbosity defaultVerbosity) =>
     public static Option<Verbosity?> VerbosityOption() =>
         new Option<Verbosity?>("--verbosity", "-v", "--v", "-verbosity", "/v", "/verbosity")
         {
-            Description = CliStrings.VerbosityOptionDescription,
+            Description = string.Format(CliStrings.VerbosityOptionDescription, string.Join(", ", VerbosityData.VerbosityNames)),
             HelpName = CliStrings.LevelArgumentName,
             CustomParser = ParseVerbosityEnum
         }
@@ -173,7 +173,7 @@ public static Option<Verbosity> VerbosityOption(Verbosity defaultVerbosity) =>
             {
                 [var single] => single.Value,
                 [.., var last] => last.Value,
-                _ => throw new InvalidOperationException("Unreachable")
+                _ => throw new System.Diagnostics.UnreachableException()
             };
 
         // happy path: someone used the fully enum case name
@@ -198,7 +198,7 @@ public static Option<Verbosity> VerbosityOption(Verbosity defaultVerbosity) =>
         }
         else // we couldn't parse it, so report an error
         {
-            result.AddError($"'{tokenToParse}' is not a valid value for --verbosity. Allowed values are: quiet (q), minimal (m), normal (n), detailed (d), diagnostic (diag).");
+            result.AddError(string.Format(CliStrings.VerbosityParserInvalidToken, tokenToParse, string.Join(", ", VerbosityData.VerbosityNames)));
             return default;
         }
     }