Simplify code: merge recursive methods and remove irrelevant increment/decrement checks

Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com>

Author: Copilot

src/Microsoft.CodeAnalysis.NetAnalyzers/src/Microsoft.CodeAnalysis.NetAnalyzers/Microsoft.NetCore.Analyzers/Runtime/AvoidRedundantRegexIsMatchBeforeMatch.cs

@@ -86,13 +86,7 @@ private static bool IsRegexIsMatchCall(IOperation condition, ImmutableArray<IMet
             return false;
         }
 
-        private static bool FindMatchCallInBranch(IOperation branch, ImmutableArray<IMethodSymbol> regexMatchSymbols, IInvocationOperation isMatchCall, IOperation conditionalOperation, out IInvocationOperation matchCall)
-        {
-            // Search for the first Match call that matches criteria
-            return FindMatchCallRecursive(branch, regexMatchSymbols, isMatchCall, conditionalOperation, out matchCall);
-        }
-
-        private static bool FindMatchCallRecursive(IOperation operation, ImmutableArray<IMethodSymbol> regexMatchSymbols, IInvocationOperation isMatchCall, IOperation conditionalOperation, out IInvocationOperation matchCall)
+        private static bool FindMatchCallInBranch(IOperation operation, ImmutableArray<IMethodSymbol> regexMatchSymbols, IInvocationOperation isMatchCall, IOperation conditionalOperation, out IInvocationOperation matchCall)
         {
             if (operation is IInvocationOperation invocation &&
                 regexMatchSymbols.Contains(invocation.TargetMethod, SymbolEqualityComparer.Default))
@@ -107,7 +101,7 @@ private static bool FindMatchCallRecursive(IOperation operation, ImmutableArray<
 
             foreach (var child in operation.Children)
             {
-                if (FindMatchCallRecursive(child, regexMatchSymbols, isMatchCall, conditionalOperation, out matchCall))
+                if (FindMatchCallInBranch(child, regexMatchSymbols, isMatchCall, conditionalOperation, out matchCall))
                 {
                     return true;
                 }
@@ -261,7 +255,7 @@ private static bool HasAssignmentToSymbol(ISymbol symbol, IOperation operation)
                 }
             }
 
-            // Check for compound assignments
+            // Check for compound assignments (e.g., +=, -=, etc.)
             if (operation is ICompoundAssignmentOperation compoundAssignment)
             {
                 if (compoundAssignment.Target is ILocalReferenceOperation compoundTargetLocal &&
@@ -276,21 +270,6 @@ private static bool HasAssignmentToSymbol(ISymbol symbol, IOperation operation)
                 }
             }
 
-            // Check for increments/decrements
-            if (operation is IIncrementOrDecrementOperation increment)
-            {
-                if (increment.Target is ILocalReferenceOperation incrementTargetLocal &&
-                    SymbolEqualityComparer.Default.Equals(incrementTargetLocal.Local, symbol))
-                {
-                    return true;
-                }
-                if (increment.Target is IParameterReferenceOperation incrementTargetParam &&
-                    SymbolEqualityComparer.Default.Equals(incrementTargetParam.Parameter, symbol))
-                {
-                    return true;
-                }
-            }
-
             // Recursively check children
             foreach (var child in operation.Children)
             {