Variable name MyStringBuilder -> myStringbuilder #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rpetrusha
added
the
✨ 1st-time samples contributor!
rpetrusha
suggested changes
Jun 27, 2018
There was a problem hiding this comment.
Thanks for contributing to the dotnet/samples repo and for camel casing the variable name, @majikandy. There are also Visual Basic and C++ code examples. Could you change the casing in those as well?
|
Yes, absolutely, I'll do that |
|
done |
rpetrusha
approved these changes
Jun 27, 2018
There was a problem hiding this comment.
Thanks, @majikandy, for adding the VB and C++ files to your PR. I'll merge your PR now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
to make it clearer that myStringBuilder is the variable.
See also the docs that reference this, paragraph there also updated for the 1 mention of the instance variable name.
dotnet/docs#6162