update samples for stackalloc #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved samples from the snippets folder in the dotnet/docs repo. Add project file and main program to run snippets. Add second sample that uses stackalloc initializers.
BillWagner
added
the
🚧 Hold for related PR
rpetrusha
approved these changes
Apr 11, 2018
rpetrusha
left a comment
rpetrusha
left a comment
There was a problem hiding this comment.
LGTM, @BillWagner. Left just one very minor comment.
| @@ -0,0 +1,104 @@ | |||
| using System; | |||
| using System.Collections.Generic; | |||
There was a problem hiding this comment.
is there any reason to include System.Collections.Generic and System.Text?
pkulikov
reviewed
Apr 12, 2018
| 0b0001_0000_0000_0000, | ||
| 0b0010_0000_0000_0000, | ||
| 0b0100_0000_0000_0000, | ||
| 0b1000_0000_0000_0000 |
Contributor
There was a problem hiding this comment.
nit: would adding one more underscore to literals make it more readable, e.g., 0b_1000_0000_0000_0000?
karelz
pushed a commit
to karelz/samples
that referenced
this pull request
Aug 31, 2018
* update samples for stackalloc Moved samples from the snippets folder in the dotnet/docs repo. Add project file and main program to run snippets. Add second sample that uses stackalloc initializers. * respond to feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved samples from the snippets folder in the dotnet/docs repo.
Add project file and main program to run snippets.
Add second sample that uses stackalloc initializers.
Samples for dotnet/docs#4772
Must merge with dotnet/docs#4922