Skip to content

Use attributes for IsDynamicCodeSupported feature switch #99641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 13, 2024
Merged

Use attributes for IsDynamicCodeSupported feature switch #99641

merged 2 commits into from
Mar 13, 2024

Conversation

@sbomer
Copy link
Member

@sbomer sbomer commented Mar 12, 2024 •
edited
Loading

And remove some warning suppression pragmas.

Fixes #97273 (the analyzer will now be able to see that IsDynamicCodeCompiled guards APIs annotated with RequiresDynamicCodeAttribute).

@ghost ghost added needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners new-api-needs-documentation labels Mar 12, 2024
@ghost
Copy link

ghost commented Mar 12, 2024

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@sbomer @AustinWise
Update src/libraries/System.Linq.Expressions/src/System/Dynamic/Utils…
0f58191 
…/TypeUtils.cs

Co-authored-by: Austin Wise <AustinWise@gmail.com>
@build-analysis build-analysis bot mentioned this pull request Mar 13, 2024
Closed
@sbomer sbomer merged commit eb864bf into dotnet:main Mar 13, 2024
@filipnavara filipnavara mentioned this pull request Mar 25, 2024
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MichalStrehovsky MichalStrehovsky MichalStrehovsky approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar

+1 more reviewer

@AustinWise AustinWise AustinWise left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@sbomer sbomer

Labels

needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners new-api-needs-documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

False positives for IL3050, despite runtime feature checks

3 participants

@sbomer @AustinWise @MichalStrehovsky