JIT: Add fgRedirectTrueEdge, fgRedirectFalseEdge #99561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
51 tasks
|
Diffs are quite big, though the bulk of them seem to come from a few collections. I'll dig into these locally. |
AndyAyersMS
reviewed
Mar 12, 2024
| @@ -449,6 +449,84 @@ void Compiler::fgRedirectTargetEdge(BasicBlock* block, BasicBlock* newTarget) | |||
| newTarget->bbRefs++; | |||
| } | |||
|
|
|||
| void Compiler::fgRedirectTrueEdge(BasicBlock* block, BasicBlock* newTarget) | |||
There was a problem hiding this comment.
Please add a header comment block for this method
| assert(newTarget->checkPredListOrder()); | ||
| } | ||
|
|
||
| void Compiler::fgRedirectFalseEdge(BasicBlock* block, BasicBlock* newTarget) |
There was a problem hiding this comment.
Please add a header comment block for this method
src/coreclr/jit/fgflow.cpp
Outdated
|
|
||
| newTarget->bbRefs++; | ||
|
|
||
| // Pred list of target should (stilL) be ordered |
There was a problem hiding this comment.
Suggested change
| // Pred list of target should (stilL) be ordered | |
| // Pred list of target should (still) be ordered |
src/coreclr/jit/fgflow.cpp
Outdated
|
|
||
| newTarget->bbRefs++; | ||
|
|
||
| // Pred list of target should (stilL) be ordered |
There was a problem hiding this comment.
Suggested change
| // Pred list of target should (stilL) be ordered | |
| // Pred list of target should (still) be ordered |
|
@AndyAyersMS thanks for the review -- I incorporated your feedback. |
AndyAyersMS
approved these changes
Mar 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #99362. Adds helper methods for redirecting BBJ_COND blocks' true/false targets to new successors while reusing the existing flow edge.
cc @dotnet/jit-contrib, @AndyAyersMS PTAL. This may conflict with #99541; I'm ok with waiting for that to be merged first.