set scope and build validation in dev when no options provided #99199
Conversation
|
Tagging subscribers to this area: @dotnet/area-extensions-hosting Issue DetailsResolves issue #97091
|
|
@benjaminpetit could you take a look please? |
ericstj
added
the
breaking-change
dotnet-policy-service
bot
added
the
needs-breaking-change-doc-created
|
Added When you commit this breaking change:
Tagging @dotnet/compat for awareness of the breaking change. |
|
|
||
| /// <summary> | ||
| /// Initializes a new instance of <see cref="HostBuilder"/>. | ||
| /// </summary> | ||
| public HostBuilder() | ||
| { | ||
| _serviceProviderFactory = new ServiceFactoryAdapter<IServiceCollection>(new DefaultServiceProviderFactory()); | ||
| _defaultProviderFactoryUsed = true; |
There was a problem hiding this comment.
Where is this ever set to false? Should that be done in UseServiceProviderFactory?
There was a problem hiding this comment.
Yes, it seems to me that this field should be set to false when UseServiceProviderFactory is called. This was my oversight I believe.
|
I marked this PR as breaking since it introduces new validation by default when in Development environment. |
|
@steveharter or @wcsanders1 can you please create a breaking change doc for the new defaults for Update - I went ahead and created it, please review what I've created. dotnet/docs#41887 |
Resolves issue #97091