Revert "Add an internal mode to Lock to have it use non-alertable w…
#98867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aits (dotnet#97227)" This reverts commit e568f75.
ghost
added
the
needs-area-label
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue Details…aits (#97227)" This reverts commit e568f75. This change caused a significant perf regression in ASP.NET GRPC and WebAPI scenarios as detailed in #98021 @kouvel Feel free to bring this change back after the cause of the regression has been fixed.
|
kouvel
approved these changes
Feb 23, 2024
This was referenced Feb 23, 2024
This was referenced Feb 24, 2024
kouvel
added a commit
that referenced
this pull request
Mar 7, 2024
) * Reapply "Add an internal mode to `Lock` to have it use non-alertable waits (#97227)" (#98867) This reverts commit f129701. * Fix Lock's waiter duration computation PR #97227 introduced a tick count masking issue where the stored waiter start time excludes the upper bit from the ushort tick count, but comparisons with it were not doing the appropriate masking. This was leading to a lock convoy on some heavily contended locks once in a while due to waiters incorrectly appearing to have waited for a long time. Fixes #98021 * Fix wraparound issue * Fix recording waiter start time * Use a bit in the _state field instead
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…aits (#97227)"
This reverts commit e568f75.
This change caused a significant perf regression in ASP.NET GRPC and WebAPI scenarios as detailed in #98021
@kouvel Feel free to bring this change back after the cause of the regression has been fixed.