Skip to content

[NativeAOT] Fix exceptions thrown by LDiv/LMod helpers #98474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 15, 2024
Merged

[NativeAOT] Fix exceptions thrown by LDiv/LMod helpers #98474

merged 1 commit into from
Feb 15, 2024

Conversation

filipnavara
Copy link
Member

Fixes the following Pri0 tests:

  • JIT/CodeGenBringUpTests/DivConst_d/DivConst_d.dll
  • JIT/CodeGenBringUpTests/DivConst_do/DivConst_do.dll
  • JIT/CodeGenBringUpTests/DivConst_r/DivConst_r.dll
  • JIT/CodeGenBringUpTests/DivConst_ro/DivConst_ro.dll
  • JIT/CodeGenBringUpTests/ModConst_d/ModConst_d.dll
  • JIT/CodeGenBringUpTests/ModConst_do/ModConst_do.dll
  • JIT/CodeGenBringUpTests/ModConst_r/ModConst_r.dll
  • JIT/CodeGenBringUpTests/ModConst_ro/ModConst_ro.dll
  • JIT/IL_Conformance/Old/Conformance_Base/rem_i8/rem_i8.dll
  • JIT/jit64/regress/vsw/543645/test_543645/test_543645.dll

Contributes to #97729

@filipnavara filipnavara requested a review from jkotas February 15, 2024 03:23
@ghost
Copy link

ghost commented Feb 15, 2024

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes the following Pri0 tests:

  • JIT/CodeGenBringUpTests/DivConst_d/DivConst_d.dll
  • JIT/CodeGenBringUpTests/DivConst_do/DivConst_do.dll
  • JIT/CodeGenBringUpTests/DivConst_r/DivConst_r.dll
  • JIT/CodeGenBringUpTests/DivConst_ro/DivConst_ro.dll
  • JIT/CodeGenBringUpTests/ModConst_d/ModConst_d.dll
  • JIT/CodeGenBringUpTests/ModConst_do/ModConst_do.dll
  • JIT/CodeGenBringUpTests/ModConst_r/ModConst_r.dll
  • JIT/CodeGenBringUpTests/ModConst_ro/ModConst_ro.dll
  • JIT/IL_Conformance/Old/Conformance_Base/rem_i8/rem_i8.dll
  • JIT/jit64/regress/vsw/543645/test_543645/test_543645.dll

Contributes to #97729

Author: filipnavara
Assignees: -
Labels:

area-NativeAOT-coreclr
Milestone: -

@filipnavara filipnavara added arch-arm32 community-contribution Indicates that the PR has been added by a community member labels Feb 15, 2024
@filipnavara filipnavara mentioned this pull request Feb 15, 2024
Merged
jkotas
jkotas approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jkotas jkotas merged commit 741c0c8 into dotnet:main Feb 15, 2024
@build-analysis build-analysis bot mentioned this pull request Feb 15, 2024
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2024
@filipnavara filipnavara deleted the lmod_ldiv branch June 5, 2025 07:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

Assignees
No one assigned
Labels
arch-arm32 area-NativeAOT-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filipnavara @jkotas