-
Notifications
You must be signed in to change notification settings - Fork 5k
Remove GetDomain
functions on assorted method/type/assembly classes which are always in the single app domain
#98135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are several places where BaseDomain::IsAppDomain()
is called. Ideally BaseDomain
would be an abstract class so that is fine, but what about the SystemDomain
. Did we confirm that SystemDomain
is never cast to a BaseDomain
and passed around?
I checked this for the things I touched. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
GetDomain
functions onMethodDesc
,MethodTable
,TypeDesc
, andTypeHandle
. They always return the single current app domain.GetDomain
functions and variables onAssembly
,DomainAssembly
, andModule
. The actual domain they are constructed with is always the single current app domain.