-
Notifications
You must be signed in to change notification settings - Fork 5k
Update latest roslyn version to 4.8 #97767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jkoritzinsky
merged 6 commits into
dotnet:main
from
DoctorKrolic:update-code-analysis-version
Jan 31, 2024
Merged
Update latest roslyn version to 4.8 #97767
jkoritzinsky
merged 6 commits into
dotnet:main
from
DoctorKrolic:update-code-analysis-version
Jan 31, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorHofer
approved these changes
Jan 31, 2024
I approved this but it's @jkoritzinsky who introduced these properties. Jeremy, PTAL. |
This was referenced Jan 31, 2024
…torKrolic/runtime into update-code-analysis-version
ViktorHofer
reviewed
Jan 31, 2024
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
ViktorHofer
approved these changes
Jan 31, 2024
We're going to need to update the sourcebuild baseline. Can you update this line to refer to 4.8?
|
I thought this would be easier... @jkoritzinsky PTAL |
ViktorHofer
approved these changes
Jan 31, 2024
jkoritzinsky
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Failures are all known. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-crossgen2-coreclr
community-contribution
Indicates that the PR has been added by a community member
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to use new language features like collection expressions e.g. in #96964