-
Notifications
You must be signed in to change notification settings - Fork 5k
Add APIs for allocation-free delegate invocation list inspection #97683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
Tagging subscribers to this area: @dotnet/area-system-runtime Issue DetailsFixes #41849
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
Looks like there are a few places we could use HasSingleTarget, e.g. runtime/src/libraries/System.ObjectModel/src/System/Collections/ObjectModel/ObservableCollection.cs Line 231 in 2d49c2f
runtime/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/BindingList.cs Line 304 in 2d49c2f
(though I don't understand that second one... won't _onAddingNew.GetInvocationList().Length > 0 always be true?)
|
And a few places we could enumerate more cheaply? runtime/src/libraries/System.Private.CoreLib/src/System/Runtime/Loader/AssemblyLoadContext.cs Line 630 in 2d49c2f
runtime/src/libraries/System.Private.CoreLib/src/System/Runtime/Loader/AssemblyLoadContext.cs Line 744 in 2d49c2f
runtime/src/libraries/System.Private.CoreLib/src/System/Runtime/Loader/AssemblyLoadContext.cs Line 825 in 2d49c2f
|
Co-authored-by: Stephen Toub <stoub@microsoft.com>
src/libraries/System.ObjectModel/src/System/Collections/ObjectModel/ObservableCollection.cs
Show resolved
Hide resolved
src/libraries/System.Runtime/tests/System.Runtime.Tests/System/MulticastDelegateTests.cs
Outdated
Show resolved
Hide resolved
…/MulticastDelegateTests.cs Co-authored-by: Stephen Toub <stoub@microsoft.com>
src/mono/System.Private.CoreLib/src/System/MulticastDelegate.cs
Outdated
Show resolved
Hide resolved
All failures are known according to the build analysis |
Fixes #41849