Skip to content

[wasm][mt] Fix System.Threading.Tasks.Parallel build #97505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 26, 2024
Merged

[wasm][mt] Fix System.Threading.Tasks.Parallel build #97505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5644f37
[wasm][mt] Fix System.Threading.Tasks.Parallel build
radekdoulik Jan 25, 2024
8f40d96
Enable 5 more tests
radekdoulik Jan 25, 2024
90ac6c9
Merge branch 'main' into pr-wasm-mt-fix-sttp-build
radekdoulik Jan 25, 2024
7d52b40
Merge branch 'main' into pr-wasm-mt-fix-sttp-build
radekdoulik Jan 25, 2024
ec393b7
Feedback
radekdoulik Jan 26, 2024
3a840ad
Fix typo
radekdoulik Jan 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libraries/System.Threading.Tasks.Parallel/src/System.Threading.Tasks.Parallel.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>$(NetCoreAppCurrent)</TargetFramework>
<TargetFrameworks>$(NetCoreAppCurrent);$(NetCoreAppCurrent)-browser</TargetFrameworks>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<UseCompilerGeneratedDocXmlFile>false</UseCompilerGeneratedDocXmlFile>
</PropertyGroup>
Expand Down
2 changes: 0 additions & 2 deletions src/libraries/System.Threading.Tasks.Parallel/tests/ParallelForTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -885,7 +885,6 @@ public static void TestParallelForPaths_Exceptions()
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/91582", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))]
public static void TestParallelScheduler()
{
ParallelOptions parallelOptions = new ParallelOptions();
Expand Down Expand Up @@ -993,7 +992,6 @@ public static void TestParallelScheduler()
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/91541", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))]
public static void TestInvokeDOPAndCancel()
{
ParallelOptions parallelOptions = null;
Expand Down
1 change: 0 additions & 1 deletion src/libraries/System.Threading.Tasks.Parallel/tests/ParallelLoopResultTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,6 @@ private static void OrderablePartitionerForEachPLRTest(

// Perform tests on various combinations of Stop()/Break()
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/91579", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))]
public static void SimultaneousStopBreakTests()
{
//
Expand Down
2 changes: 0 additions & 2 deletions src/libraries/System.Threading.Tasks.Parallel/tests/RangePartitioner1Chunk.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ static void oneMoveNext(int length, bool isOrderable)
/// </summary>
/// <param name="length"></param>
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/97396", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))]
public static void IterationsWithDependency()
{
static void iterationsWithDependency(int length, int dependencyIndex)
Expand Down Expand Up @@ -167,7 +166,6 @@ public static void PFEDisposeEnum()
/// Exception is expected and the enumerators are disposed
/// </summary>
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/91581", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))]
public static void ExceptionOnMoveNext()
{
static void exceptionOnMoveNext(int length, int indexToThrow, bool isOrderable)
Expand Down
1 change: 0 additions & 1 deletion src/libraries/System.Threading.Tasks.Parallel/tests/RangePartitionerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ namespace System.Threading.Tasks.Tests
public static class RangePartitionerTests
{
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/97440", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))]
public static void RunPartitionerStaticTest_SingleChunking()
{
CountdownEvent cde = new CountdownEvent(2);
Expand Down