Skip to content

[perf] Use HybridGlobalization as default and only option for Apple mobile platforms #96918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kotlarmilos
Copy link
Member

Description

This PR updates the CI to runs iOS jobs using hybrid globalization exclusively. The Apple mobile platforms rely on the system ICU provided by the Apple SDK. Following the changes introduced in #93220, the HybridGlobalization is the default and only option for Apple mobile platforms.

Fixes #96868

@kotlarmilos kotlarmilos added this to the 9.0.0 milestone Jan 12, 2024
@kotlarmilos kotlarmilos self-assigned this Jan 12, 2024
@kotlarmilos kotlarmilos requested a review from radical as a code owner January 12, 2024 22:05
@ghost
Copy link

ghost commented Jan 12, 2024

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Description

This PR updates the CI to runs iOS jobs using hybrid globalization exclusively. The Apple mobile platforms rely on the system ICU provided by the Apple SDK. Following the changes introduced in #93220, the HybridGlobalization is the default and only option for Apple mobile platforms.

Fixes #96868

Author: kotlarmilos
Assignees: kotlarmilos
Labels:

tenet-performance, area-Infrastructure-mono

Milestone: 9.0.0

@kotlarmilos
Copy link
Member Author

Copy link
Member

@LoopedBard3 LoopedBard3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me given a generally successful test run.

@kotlarmilos kotlarmilos merged commit d7604b6 into dotnet:main Jan 15, 2024
tmds pushed a commit to tmds/runtime that referenced this pull request Jan 23, 2024
…obile platforms (dotnet#96918)

* [perf] Use HybridGlobalization as default and only option for Apple mobile platforms

---------

Co-authored-by: Ankit Jain <radical@gmail.com>
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS NativeAOT testing app failing to build in performance pipeline
4 participants