[release/8.0-staging] Fix Vector512.CopyTo #95026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dotnet-issue-labeler
bot
added
the
needs-area-label
tannergooding
added
Servicing-consider
|
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics Issue DetailsBackport of #94795 to release/8.0-staging /cc @tannergooding @MichalPetryka Customer ImpactUsers using TestingRegression tests covering the scenario were added. RiskLow. This is a net new API in .NET 8 and one where the implementation has been adjusted to match the existing known good implementations used by the other vector types (such as Vector128 and Vector256).
|
jeffhandley
approved these changes
Nov 20, 2023
jeffhandley
added
Servicing-approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #94795 to release/8.0-staging
/cc @tannergooding @MichalPetryka
Customer Impact
Users using
Vector512.CopyTo(a new API in .NET 8) will see incorrect results as the wrong data would be copied.Testing
Regression tests covering the scenario were added.
Risk
Low. This is a net new API in .NET 8 and one where the implementation has been adjusted to match the existing known good implementations used by the other vector types (such as Vector128 and Vector256).