Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to servicing branding #94526

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Update to servicing branding #94526

merged 1 commit into from
Nov 8, 2023

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented Nov 8, 2023

No description provided.

@ghost
Copy link

ghost commented Nov 8, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: mmitche
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for missing that one. Thanks for submitting the fix.

@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Nov 8, 2023
@carlossanlop
Copy link
Member

carlossanlop commented Nov 8, 2023

From a conversation with the wasm team, the CI failures seem to have the same root cause as #93900 but with a different failure message. I can merge this now. I need to create a separate KnownBuildError issue to track this other error message, even if it's the same as the existing issue.

The osx failure was a curl failure: https://dev.azure.com/dnceng-public/public/_build/results?buildId=463693&view=logs&j=1131d339-d842-59c0-dcc0-73e7a31acc11&t=9c8d0f40-0c4c-53c5-f33c-9e8e40de8387&l=35

@carlossanlop carlossanlop merged commit d8e7996 into release/8.0 Nov 8, 2023
172 of 184 checks passed
@carlossanlop carlossanlop deleted the mmitche-patch-1 branch November 8, 2023 19:51
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants