[browser][MT] fix stale memory on suspended thread

[pavelsavara]

Alternative to #90771

Problem: when WebWorker is suspended in the browser, the other running threads could grow the linear memory in the meantime. After the thread is un-suspended it may to try to de-reference pointer which is beyond it's known view. This is likely V8 bug.

We believe that described problem is cause of MT problems with debugger tests, example log

[ghost]

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

---

testing alternative to #90771

Problem: when WebWorker is suspended in the browser, the other running threads could grow the linear memory in the meantime. After the thread is un-suspended it may to try to de-reference pointer which is beyond it's known view. This is likely V8 bug.

We believe that described problem is cause of MT problems with debugger tests, example log

Author:	pavelsavara
Assignees:	pavelsavara
Labels:	arch-wasm, area-System.Runtime.InteropServices.JavaScript, os-browser
Milestone:	9.0.0

[pavelsavara]

/azp run runtime-wasm

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[pavelsavara]

This helps

[pavelsavara]

/azp run runtime-wasm

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[pavelsavara]

@thaystg I will wait for your feedback/approval

[pavelsavara]

/azp run runtime-wasm

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[pavelsavara]

Hmm, so now all errors are "TypeError: Failed to fetch\n at Object.L [as fetch_like] (http://localhost:9400/_framework/dotnet.js:3:4721)\n at http://localhost:9400/_framework/dotnet.js:3:12002\n at http://localhost:9400/_framework/dotnet.js:3:12018" Log

@thaystg does that mean my fix didn't help ? Or it means there is another issue ?

Is debugger making the app to download something ?

Does suspending thread while fetching break the fetch ?

[thaystg]

I think there are a lot of core dumps generated: chrome is crashing, not sure if it's related to your fix.

[thaystg]

I also remember to have already tried it and it didn't help. But for me it's okay to try again. :)

[pavelsavara]

I think there are a lot of core dumps generated: chrome is crashing, not sure if it's related to your fix.

Where is "there" ?

More details would help.

I also remember to have already tried it and it didn't help. But for me it's okay to try again. :)

Could you please elaborate on what you tried ?

[thaystg]

I think there are a lot of core dumps generated: chrome is crashing, not sure if it's related to your fix.

Where is "there" ?

More details would help.

I also remember to have already tried it and it didn't help. But for me it's okay to try again. :)

Could you please elaborate on what you tried ?

Look at artifacts tab here: https://dev.azure.com/dnceng-public/public/_build/results?buildId=459235&view=ms.vss-test-web.build-test-results-tab&runId=10361536&resultId=100252&paneView=dotnet-dnceng.dnceng-build-release-tasks.helix-test-information-tab

[thaystg]

Could you please elaborate on what you tried ?

Unfortunately I don't remember details of what I tested, I tried a lot of things before the workaround in that PR.
If I can help you in anyway by testing your solution or anything else, please let me know.

[pavelsavara]

/azp run runtime-wasm

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[pavelsavara]

/azp run runtime-wasm

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[pavelsavara]

[pavelsavara]

/azp run runtime-wasm

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[pavelsavara]

/azp run runtime-wasm

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[pavelsavara]

/azp run runtime-wasm

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[pavelsavara]

I think that the fix for memory views is good. Solid 10/10

There are problems with #89409 but that's unrelated issue

The active test run was aborted. Reason: Test host process crashed
Results File: /root/helix/work/workitem/uploads/xharness-output/logs/testResults.trx

Passed!  - Failed:     0, Passed:    80, Skipped:     0, Total:    80, Duration: 9 m - DebuggerTestSuite.dll (net8.0)
Test Run Aborted.

[thaystg]

@pavelsavara thanks a lot and congrats for this fix!!!