[release/8.0-staging] Fix literal formatting in source generators #94070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Both ConfigurationBinder and Json were not handling decimal values correctly. This shares and updates our workaround method for formatting these.
dotnet-issue-labeler
bot
added
the
needs-area-label
ericstj
added
area-Extensions-Configuration
and removed
needs-area-label
|
Tagging subscribers to this area: @dotnet/area-extensions-configuration Issue DetailsBackport of #93160 to release/8.0-staging /cc @ericstj Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
ericstj
changed the title
ericstj
added
the
NO-MERGE
tarekgh
approved these changes
Oct 26, 2023
eiriktsarpalis
approved these changes
Oct 27, 2023
eerhardt
reviewed
Oct 27, 2023
src/libraries/System.Text.Json/tests/Common/TestClasses/TestClasses.Constructor.cs
Show resolved
Hide resolved
… into backport/pr-93160-to-release/8.0-staging
* Add a baseline test for constructor parameters * Fix binding types with optional string parameters Ensure the source generator emits the declaration with default value for all cases when we emit the bind logic. * Add a test case that uses a Primary Constructor with default values * Split baseline data for added test. * Fix .NETFramework test baseline * Update baselines after global namespace change # Conflicts:
ericstj
added
Servicing-consider
|
Ok, I ported the handling for string parameters too. Can I get another review? FYI @artl93 we want to bring this for servicing. |
artl93
approved these changes
Nov 7, 2023
tarekgh
approved these changes
Nov 7, 2023
|
Need to merge latest due to global:: change going in. |
… into backport/pr-93160-to-release/8.0-staging
ericstj
added
Servicing-approved
|
Approved over email |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #93160 to release/8.0-staging
/cc @ericstj
Customer Impact
Cannot use ConfigurationBinder source generator when a configuration type has a constructor with optional parameters of type Enum, Decimal, or string. Generator produces code which doesn't compile.
Testing
Automated tests added to cover types usable in of optional parameters. Baseline tests added as well to track the code-generation for these scenarios.
Risk
Low. Only touches Configuration & Json source generators and reuses a method that was already working in JSON.
Package versioning was done in #94307