[browser][MT] unify pthread pool size to 32 #94056

pavelsavara · 2023-10-26T17:15:14Z

bump default thread pool size to 32 and unify to that default for all tests
see which existing active issues are caused by the same reason
keep ActiveIssue tracking it, because we know that it's too large default
- [browser][MT] RandomTests.Shared_ParallelUsage #91538

ghost · 2023-10-26T17:15:21Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

bump default thread pool size to 16 and unify to that default for all tests
see which existing active issues are caused by the same reason
keep ActiveIssue tracking it, because we know that it's too large default
- [browser][MT] RandomTests.Shared_ParallelUsage #91538

Author:	pavelsavara
Assignees:	pavelsavara
Labels:	`arch-wasm`, `area-VM-threading-mono`, `os-browser`
Milestone:	9.0.0

pavelsavara · 2023-10-26T17:15:44Z

/azp run runtime-wasm

azure-pipelines · 2023-10-26T17:15:55Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2023-10-27T10:05:10Z

/azp run runtime-wasm

azure-pipelines · 2023-10-27T10:05:28Z

Azure Pipelines successfully started running 1 pipeline(s).

…sdk (dotnet#93929) * Update dependencies from https://github.com/dotnet/arcade build 20231023.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.23518.2 -> To Version 9.0.0-beta.23523.2 * Update dependencies from https://github.com/dotnet/arcade build 20231024.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.23518.2 -> To Version 9.0.0-beta.23524.1 Dependency coherency updates Microsoft.DotNet.XliffTasks From Version 1.0.0-beta.23516.1 -> To Version 1.0.0-beta.23523.1 (parent: Microsoft.DotNet.Helix.Sdk * Update dependencies from https://github.com/dotnet/arcade build 20231024.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.23518.2 -> To Version 9.0.0-beta.23524.1 Dependency coherency updates Microsoft.DotNet.XliffTasks From Version 1.0.0-beta.23516.1 -> To Version 1.0.0-beta.23523.1 (parent: Microsoft.DotNet.Helix.Sdk * Update dependencies from https://github.com/dotnet/xharness build 20231025.2 Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 8.0.0-prerelease.23523.1 -> To Version 8.0.0-prerelease.23525.2 * Update dependencies from https://github.com/dotnet/sdk build 20231025.7 Microsoft.DotNet.ApiCompat.Task From Version 9.0.100-alpha.1.23524.12 -> To Version 9.0.100-alpha.1.23525.7 * Update dependencies from https://github.com/dotnet/arcade build 20231025.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.23518.2 -> To Version 9.0.0-beta.23525.2 Dependency coherency updates Microsoft.DotNet.XliffTasks From Version 1.0.0-beta.23516.1 -> To Version 1.0.0-beta.23523.1 (parent: Microsoft.DotNet.Helix.Sdk * Update dependencies from https://github.com/dotnet/xharness build 20231026.1 Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 8.0.0-prerelease.23523.1 -> To Version 9.0.0-prerelease.23526.1 * Update dependencies from https://github.com/dotnet/sdk build 20231025.29 Microsoft.DotNet.ApiCompat.Task From Version 9.0.100-alpha.1.23524.12 -> To Version 9.0.100-alpha.1.23525.29 * Try inheriting from LongLivedMarshalByRefObject * Resolve XUnit ambiguity * Just disable the warning --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Andy Gocke <andy@commentout.net>

This reverts commit fa294c0.

pavelsavara · 2023-10-27T13:49:53Z

/azp run runtime-wasm

azure-pipelines · 2023-10-27T13:50:04Z

Azure Pipelines successfully started running 1 pipeline(s).

…ipeline (dotnet#91536)"

pavelsavara · 2023-10-27T15:37:25Z

/azp run runtime-wasm

azure-pipelines · 2023-10-27T15:37:43Z

Azure Pipelines successfully started running 1 pipeline(s).

…3809) * Abstract LocalBuilder, emit LocalBuilder in ILGenerator * Apply suggestions from code review Co-authored-by: Aaron Robinson <arobins@microsoft.com> * Remove public LocalBuilder.Method, and apply other feedback * Avoid invalid cast exception. Co-authored-by: Jan Kotas <jkotas@microsoft.com> --------- Co-authored-by: Aaron Robinson <arobins@microsoft.com> Co-authored-by: Jan Kotas <jkotas@microsoft.com>

* Interlocked intrinsic improvements * Format

* Fold "X >= 0 && X < NN" to "X u< NN" * Relax to GTF_SIDE_EFFECT

* Update dependencies from https://github.com/dotnet/arcade build 20231027.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.23525.2 -> To Version 9.0.0-beta.23527.1 Dependency coherency updates Microsoft.DotNet.XliffTasks From Version 1.0.0-beta.23523.1 -> To Version 1.0.0-beta.23525.5 (parent: Microsoft.DotNet.Helix.Sdk * Update dependencies from https://github.com/dotnet/sdk build 20231027.4 Microsoft.DotNet.ApiCompat.Task From Version 9.0.100-alpha.1.23525.29 -> To Version 9.0.100-alpha.1.23527.4 --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

* Update dependencies from https://github.com/dotnet/arcade build 20231027.3 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.23527.1 -> To Version 9.0.0-beta.23527.3 * React to xliff-tasks -> arcade repo consolidation --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>

…dotnet#94136) * Update dependencies from https://github.com/dotnet/arcade build 20231027.4 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.23527.3 -> To Version 9.0.0-beta.23527.4 * Update dependencies from https://github.com/dotnet/emsdk build 20231028.1 Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport From Version 9.0.0-alpha.1.23523.3 -> To Version 9.0.0-alpha.1.23528.1 * Update dependencies from https://github.com/dotnet/sdk build 20231028.1 Microsoft.DotNet.ApiCompat.Task From Version 9.0.100-alpha.1.23527.4 -> To Version 9.0.100-alpha.1.23528.1 * Update dependencies from https://github.com/dotnet/arcade build 20231028.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.23527.3 -> To Version 9.0.0-beta.23528.1 --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

* Disable two socket tests * Revert close to dispose * Disable tests against one issue

dotnet#91560) * Remove unused args parameter from the Main method in 349379.cs * Convert stackoverflowtester Main to individual test entrypoints * Don't complain about Exe type for test components Some tests have exe components - if these aren't marked with the CLRTestKind BuildAndRun, we shouldn't complain about them. Thanks Tomas * Make dynamicmethodliveness and ParallelCrash merge-friendly * Adjust the Tier1StackTrace test to be tolerant to merged wrappers * Convert baseservices/exceptions to merged mode * Remove constant return value 100 from the test test448035 * Make UnsafeAccessorTests owner class public * Make methods in RuntimeConfiguration/TestConfig public * Make TieredCompilation/BasicTest public * Remove unused exit code of runmoduleconstructor * Remove unused exit code of RuntimeHelperTests * Fix visibility in multidimarray/enum test * Fix visibility in TestCallingConventions test * Fix visibility in CriticalFinalizer test * Simplify RuntimeConfiguration/TestConfig * Clean up TieredCompilation tests * Convert istypeequivalent to use ConditionalFact clauses * Fix visibility in RuntimeHelpersTests * Add CoreCLRTestLibrary as a dependency of istypeequivalent * Fix merged behavior of test448035 * Fix entrypoint in 305155 * Modify TestConfig to use a separate TestConfigTester app * Additional fixes to TestConfig / TestConfigTester * Mechanically merge all remaining tests under baseservices * Fix BasicTestWithMcj, address initial Mark's PR feedback * Remove superfluous OutputType=Library annotations per Marks' PR feedback * Fix the baseservices/exceptions/unhandled test * Fix stackoverflow3 and unhandled exception tests * Remove unnecessary check from Directory.Build.targets * Fix stackoverflowtester per Mark's PR feedback

* Initial work * Tweak * Tweak * Do not generate _ilasmroundtrip.py for tests that have a generated run script * Reduce imports * Force fail to see where CI fails * Revert forcing failure. Run roundtrip on build. * Trying to fix script * Backslash tweak * Do not roundtrip the same assembly * Fixing * Remove import glob * Added is_managed_assembly * remove print * Fixed paths * Support bash. Ignore certain tests for arm. Fix poison test. * Update CLRTest.Jit.targets * Feedback. Added AssemblyChecker. * Fix paths * Update src/tests/Common/Directory.Build.targets Co-authored-by: Bruce Forstall <brucefo@microsoft.com> * Feedback * Feedback * Update AssemblyChecker.csproj * Update Program.cs * Trying to fix calling python on helix. * Remove old roundtrip script calls. Added --is-exe option for AssemblyChecker. * Tweak option: * Remove check * Remove imports * Fix build * Fix syntax errors. Fixed Popen arguments * Fixed Popen arguments * Fixing debug check * Fixing tests * Update ILVerificationTests.csproj * Fixing tests * Feedback * Feedback * Update CLRTest.Jit.targets * Added help usage flag for AssemblyChecker * Feedback on assembly-checker --------- Co-authored-by: Bruce Forstall <brucefo@microsoft.com>

Xunit error XUW1002: Tests should not unconditionally return 100. Convert to a void return.

ilonatommy

I checked and all removed issues are relevant

src/libraries/Microsoft.Extensions.HostFactoryResolver/tests/HostFactoryResolverTests.cs

src/libraries/System.Private.CoreLib/src/System/Threading/PortableThreadPool.cs

…#94171)

pavelsavara · 2023-10-30T13:55:02Z

eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml

-       # NOTE - Since threading is experimental, we don't want to block mainline work
-      shouldContinueOnError: true
+      # NOTE - Since threading is experimental, we don't want to block mainline work
+      # TODO put back shouldContinueOnError: true


we should put this back before merge

* Implement PriorityQueue.Remove * Update src/libraries/System.Collections/src/System/Collections/Generic/PriorityQueue.cs * Update src/libraries/System.Collections/src/System/Collections/Generic/PriorityQueue.cs Co-authored-by: Dan Moseley <danmose@microsoft.com> * Update src/libraries/System.Collections/src/System/Collections/Generic/PriorityQueue.cs * Update src/libraries/System.Collections/src/System/Collections/Generic/PriorityQueue.cs * Update src/libraries/System.Collections/src/System/Collections/Generic/PriorityQueue.cs Co-authored-by: Stephen Toub <stoub@microsoft.com> * Address feedback. * Address feedback * Add a Dijkstra smoke test. * Alias distance type --------- Co-authored-by: Dan Moseley <danmose@microsoft.com> Co-authored-by: Stephen Toub <stoub@microsoft.com>

… dotnet/runtime dotnet/source-build-reference-packages (dotnet#94147) * Update dependencies from https://github.com/dotnet/arcade build 20231028.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.23528.1 -> To Version 9.0.0-beta.23528.2 * Update dependencies from https://github.com/dotnet/emsdk build 20231028.4 Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport From Version 9.0.0-alpha.1.23528.1 -> To Version 9.0.0-alpha.1.23528.4 * Update dependencies from https://github.com/dotnet/sdk build 20231028.2 Microsoft.DotNet.ApiCompat.Task From Version 9.0.100-alpha.1.23528.1 -> To Version 9.0.100-alpha.1.23528.2 * Update dependencies from https://github.com/dotnet/arcade build 20231028.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.23528.1 -> To Version 9.0.0-beta.23528.2 * Update dependencies from https://github.com/dotnet/emsdk build 20231028.4 Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport From Version 9.0.0-alpha.1.23528.1 -> To Version 9.0.0-alpha.1.23528.4 * Update dependencies from https://github.com/dotnet/sdk build 20231030.1 Microsoft.DotNet.ApiCompat.Task From Version 9.0.100-alpha.1.23528.1 -> To Version 9.0.100-alpha.1.23530.1 * Update dependencies from https://github.com/dotnet/runtime build 20231029.4 Microsoft.DotNet.ILCompiler , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Text.Json From Version 9.0.0-alpha.1.23523.1 -> To Version 9.0.0-alpha.1.23529.4 * Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20231027.1 Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 9.0.0-alpha.1.23519.2 -> To Version 9.0.0-alpha.1.23527.1 --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

Remove `fgCheckStmtAfterTailCall` as it did less thorough and less correct checking. Contributes to dotnet#93246.

* Update dependencies from https://github.com/dotnet/installer build 20231027.23 Microsoft.Dotnet.Sdk.Internal From Version 9.0.100-alpha.1.23527.1 -> To Version 9.0.100-alpha.1.23527.23 * Update dependencies from https://github.com/dotnet/installer build 20231028.2 Microsoft.Dotnet.Sdk.Internal From Version 9.0.100-alpha.1.23527.1 -> To Version 9.0.100-alpha.1.23528.2 * Update dependencies from https://github.com/dotnet/installer build 20231029.1 Microsoft.Dotnet.Sdk.Internal From Version 9.0.100-alpha.1.23527.1 -> To Version 9.0.100-alpha.1.23529.1 --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

* Emit/Call member references in IL * Add more tests, add double iterations for prepopulating tokens * Emit constructor reference, add more tests * Apply feedbacks

* Expose a `Lock` type in preview mode - For now, the `Lock` type requires preview features to be enabled - Ported CoreCLR's AwareLock implementation to C# with a bit of refactoring, folded in a couple of ideas from NativeAOT's previous `Lock` implementation, and fixed a couple of issues. - Added an adaptive spin strategy to reduce CPU time from spin-waiting when spin-waits are not effective - This implementation replaces NativeAOT's `Lock` implementation. The performance of acquiring a lock under contention is improved in NativeAOT. API review: dotnet#34812

…PIs (dotnet#94128) * Initial LoadVector64/128AndUnzip APIs * Added hwintrinsics * Added generating tests * Fix semi * Whitespace * Whitespace * Whitespace * Whitespace * Whitespace * Whitespace * Fix test generation * fix missing cases in gentree * Minor formatting of the test generator * Fix comments * Fixing up tests * Use the right register variants

* Use Span to fill List<T> in more ToList scenarios * Optimize Append/Prepend changes * Update src/libraries/System.Linq/src/System/Linq/Lookup.SpeedOpt.cs Co-authored-by: Stephen Toub <stoub@microsoft.com> * Update src/libraries/System.Linq/src/System/Linq/Lookup.SpeedOpt.cs Co-authored-by: Stephen Toub <stoub@microsoft.com> * Address feedback * Remove ToSingleItemList, seems like an overoptimization --------- Co-authored-by: Stephen Toub <stoub@microsoft.com>

…#94082) RyuJIT depends on never seeing two different `CORINFO_MODULE_STRUCT` for the same thing. Fixes dotnet#93843.

…tnet#94188) * Fix Vector64x2/3/4 API comments. Minor cleanup in AdvSimd. * 4h to 4H

…/runtime into browser_mt_pool_size

pavelsavara added arch-wasm WebAssembly architecture area-VM-threading-mono os-browser Browser variant of arch-wasm labels Oct 26, 2023

pavelsavara added this to the 9.0.0 milestone Oct 26, 2023

pavelsavara requested a review from ilonatommy October 26, 2023 17:15

pavelsavara self-assigned this Oct 26, 2023

This was referenced Oct 26, 2023

Timeout in System.Net.Quic.Functional.Tests #86019

Closed

CI error: System.Net.Quic.QuicException: The connection timed out from inactivity #91757

Closed

ilonatommy mentioned this pull request Oct 27, 2023

[wasm] Runtime tests' build gets terminated with exited with code 137 #94077

Closed

wip

def6a45

pavelsavara force-pushed the browser_mt_pool_size branch from 2922082 to def6a45 Compare October 27, 2023 08:52

pavelsavara changed the title ~~[browser][MT] unify pthread pool size to 16~~ [browser][MT] unify pthread pool size to 32 Oct 27, 2023

build-analysis bot mentioned this pull request Oct 27, 2023

Test failure: Wasm.Build.Tests.NativeBuildTests.MonoAOTCross_WorksWithNoTrimming #93522

Closed

dotnet-maestro bot and others added 3 commits October 27, 2023 13:22

Revert "[arm64] Addressing modes for SIMD (dotnet#67490)" (dotnet#93981)

2dc7c31

This reverts commit fa294c0.

managed pool max threads

f134734

Revert "[browser][MT] enable all MT library tests on the runtime CI p…

6f9b06a

…ipeline (dotnet#91536)"

buyaa-n and others added 4 commits October 27, 2023 08:38

Interlocked intrinsic improvements (dotnet#93821)

aae9497

* Interlocked intrinsic improvements * Format

Fold "X >= 0 && X < NN" to "X u< NN" (dotnet#93834)

910fb04

* Fold "X >= 0 && X < NN" to "X u< NN" * Relax to GTF_SIDE_EFFECT

dotnet-maestro bot and others added 7 commits October 28, 2023 09:25

Disabling two socket tests (dotnet#93916)

b6b00ec

* Disable two socket tests * Revert close to dispose * Disable tests against one issue

Improve ArraySegment debugging (dotnet#90488)

e5c631d

Fix test returning 100 unconditionally (dotnet#94146)

7420ee7

Xunit error XUW1002: Tests should not unconditionally return 100. Convert to a void return.

ilonatommy reviewed Oct 30, 2023

View reviewed changes

src/libraries/Microsoft.Extensions.HostFactoryResolver/tests/HostFactoryResolverTests.cs Outdated Show resolved Hide resolved

src/libraries/System.Private.CoreLib/src/System/Threading/PortableThreadPool.cs Show resolved Hide resolved

build-analysis bot mentioned this pull request Oct 30, 2023

[6.0] System.Random test failure: NextInt_AllValuesAreWithinSpecifiedRange #83421

Open

Delete Interop.PrintDlg file, it was moved to dotnet/winforms (dotnet…

3295789

…#94171)

pavelsavara commented Oct 30, 2023

View reviewed changes

Rob-Hague and others added 15 commits October 30, 2023 15:24

Use SequenceEqual in BigInteger.Equals (dotnet#91416)

44a5abd

enable two HTTP POST tests (dotnet#94115)

c9a985d

JIT: update tail call IR validity checks (dotnet#94130)

7dba9af

Remove `fgCheckStmtAfterTailCall` as it did less thorough and less correct checking. Contributes to dotnet#93246.

Remove BundleLegacy test targeting netcoreapp3.0/3.1 (dotnet#94118)

97f7738

Emit/Call member references in new ILGenerator (dotnet#94116)

8d59c90

* Emit/Call member references in IL * Add more tests, add double iterations for prepopulating tokens * Emit constructor reference, add more tests * Apply feedbacks

Avoid handing out duplicate CORINFO_MODULE_STRUCT_* handles (dotnet…

848c729

…#94082) RyuJIT depends on never seeing two different `CORINFO_MODULE_STRUCT` for the same thing. Fixes dotnet#93843.

ARM64: Fix Vector64x2/3/4 API comments. Minor cleanup in AdvSimd. (do…

920cd6e

…tnet#94188) * Fix Vector64x2/3/4 API comments. Minor cleanup in AdvSimd. * 4h to 4H

Merge branch 'browser_mt_pool_size' of https://github.com/pavelsavara…

2c54204

…/runtime into browser_mt_pool_size

Revert merge bug.

e4cc570

ilonatommy closed this Oct 31, 2023

build-analysis bot mentioned this pull request Oct 31, 2023

[browser][hybridGlobalization] WBT: Hybrid Globalization fails with AOT #94212

Closed

ghost locked as resolved and limited conversation to collaborators Nov 30, 2023

pavelsavara deleted the browser_mt_pool_size branch September 2, 2024 15:34

[browser][MT] unify pthread pool size to 32 #94056

[browser][MT] unify pthread pool size to 32 #94056

Uh oh!

Conversation

pavelsavara commented Oct 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Oct 26, 2023

Uh oh!

pavelsavara commented Oct 26, 2023

Uh oh!

azure-pipelines bot commented Oct 26, 2023

Uh oh!

pavelsavara commented Oct 27, 2023

Uh oh!

azure-pipelines bot commented Oct 27, 2023

Uh oh!

pavelsavara commented Oct 27, 2023

Uh oh!

azure-pipelines bot commented Oct 27, 2023

Uh oh!

pavelsavara commented Oct 27, 2023

Uh oh!

azure-pipelines bot commented Oct 27, 2023

Uh oh!

ilonatommy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

pavelsavara Oct 30, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

30 participants

pavelsavara commented Oct 26, 2023 •

edited

Loading