Skip to content

[wasm] WBT: fix failing no-trimming test #93950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[wasm] WBT: fix failing no-trimming test #93950

wants to merge 1 commit into from

Conversation

radical
Copy link
Member

@radical radical commented Oct 24, 2023

The test build gets terminated with:
Precompiling failed for /root/helix/work/workitem/e/wbt/4hiqh2hp_nji/obj/Release/net8.0/browser-wasm/wasm/for-publish/aot-in/aot-instances.dll with exit code 137

.. while compiling aot-instances.dll, with 190+ assemblies when not
trimming. Since, the particular tests terminate the build after this
step, and don't need the output, use WasmDedup=false to avoid using
aot-instances.dll at all.

Fixes #93522

@radical
[wasm] WBT: fix failing no-trimming test
7a7b99b 
The test build gets terminated with:
`Precompiling failed for /root/helix/work/workitem/e/wbt/4hiqh2hp_nji/obj/Release/net8.0/browser-wasm/wasm/for-publish/aot-in/aot-instances.dll with exit code 137`

.. while compiling `aot-instances.dll`, with 190+ assemblies when not
trimming. Since, the particular tests terminate the build after this
step, and don't need the output, use `WasmDedup=false` to avoid using
`aot-instances.dll` at all.

Fixes dotnet#93522
@radical radical added the arch-wasm WebAssembly architecture label Oct 24, 2023
@ghost
Copy link

ghost commented Oct 24, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

The test build gets terminated with:
Precompiling failed for /root/helix/work/workitem/e/wbt/4hiqh2hp_nji/obj/Release/net8.0/browser-wasm/wasm/for-publish/aot-in/aot-instances.dll with exit code 137

.. while compiling aot-instances.dll, with 190+ assemblies when not
trimming. Since, the particular tests terminate the build after this
step, and don't need the output, use WasmDedup=false to avoid using
aot-instances.dll at all.

Fixes #93522

Author: radical
Assignees: -
Labels:

arch-wasm
Milestone: -

@ghost ghost added the area-Build-mono label Oct 24, 2023
@ghost ghost assigned radical Oct 24, 2023
@build-analysis build-analysis bot mentioned this pull request Oct 25, 2023
Closed
@vargaz
Copy link
Contributor

vargaz commented Oct 25, 2023

Note that aot+no linking will lead to very slow compilation times, so it might be a good idea to not allow it at all.

@radical
Copy link
Member Author

radical commented Oct 25, 2023

I will update the PR.

@radekdoulik
Copy link
Member

radekdoulik commented Oct 25, 2023 •
edited
Loading

Looks like we still fail with this error when compiling corelib in the latest build:
[] /root/helix/work/workitem/e/dotnet-latest/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/9.0.0-ci/Sdk/WasmApp.Native.targets(687,5): error : Precompiling failed for /root/helix/work/workitem/e/wbt/blazorwasm_Debug_aot_btjj5bk5_acb/obj/Debug/net8.0/wasm/for-publish/aot-in/System.Private.CoreLib.dll with exit code 137. [/root/helix/work/workitem/e/wbt/blazorwasm_Debug_aot_btjj5bk5_acb/blazorwasm_Debug_aot_btjj5bk5_acb.csproj]

@radical radical closed this Oct 26, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Nov 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pavelsavara pavelsavara pavelsavara approved these changes

@radekdoulik radekdoulik radekdoulik approved these changes

@maraf maraf maraf approved these changes

@lewing lewing Awaiting requested review from lewing

@ilonatommy ilonatommy Awaiting requested review from ilonatommy ilonatommy is a code owner

+1 more reviewer

@vargaz vargaz vargaz approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@radical radical

Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test failure: Wasm.Build.Tests.NativeBuildTests.MonoAOTCross_WorksWithNoTrimming
5 participants
@radical @vargaz @radekdoulik @pavelsavara @maraf