Fix binding types with optional string parameters #93563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure the source generator emits the declaration with default value for all cases when we emit the bind logic.
|
Tagging subscribers to this area: @dotnet/area-extensions-configuration Issue DetailsFixes #93159 Previously the generator would skip emitting the default in the case the member was ParsableFromStringSpec and AssignFromSectionValue. It should have only done this for the ErrorOnFailedBinding. Most of this PR is an added test to track the code-gen for default parameters.
|
tarekgh
reviewed
Oct 16, 2023
...crosoft.Extensions.Configuration.Binder/tests/Common/ConfigurationBinderTests.TestClasses.cs
Show resolved
Hide resolved
tarekgh
approved these changes
Oct 16, 2023
eiriktsarpalis
approved these changes
Oct 18, 2023
|
Added a test here. I think I'd like to combine this with #94070 since both impact the source generator's ability to handle optional parameters. |
|
Need to update this as the baselines are now stale with #94267 merged. |
ericstj
added
the
NO-MERGE
…binder-default-string-param
ericstj
removed
the
NO-MERGE
ericstj
added a commit
that referenced
this pull request
Nov 7, 2023
* Add a baseline test for constructor parameters * Fix binding types with optional string parameters Ensure the source generator emits the declaration with default value for all cases when we emit the bind logic. * Add a test case that uses a Primary Constructor with default values * Split baseline data for added test. * Fix .NETFramework test baseline * Update baselines after global namespace change # Conflicts:
ericstj
added a commit
that referenced
this pull request
Nov 8, 2023
…4070) * Fix Decimal literal formatting in source generators Both ConfigurationBinder and Json were not handling decimal values correctly. This shares and updates our workaround method for formatting these. * Address feedback * Fix binding types with optional string parameters (#93563) * Add a baseline test for constructor parameters * Fix binding types with optional string parameters Ensure the source generator emits the declaration with default value for all cases when we emit the bind logic. * Add a test case that uses a Primary Constructor with default values * Split baseline data for added test. * Fix .NETFramework test baseline * Update baselines after global namespace change # Conflicts: * Update added baseline after global:: change --------- Co-authored-by: Eric StJohn <ericstj@microsoft.com>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #93159
Previously the generator would skip emitting the default in the case the member was ParsableFromStringSpec and AssignFromSectionValue. It should have only done this for the ErrorOnFailedBinding.
Most of this PR is an added test to track the code-gen for default parameters.