Unify on one version of the ESRP tasks #92451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as the Windows signing steps.
ghost
assigned
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsChange the macos signing steps to use the same sigining tool version as the Windows signing steps.
|
hoyosjs
reviewed
Sep 22, 2023
| @@ -48,6 +48,7 @@ steps: | |||
| SessionTimeout: ${{ parameters.timeoutInMinutes }} | |||
| MaxConcurrency: '50' | |||
| MaxRetryAttempts: '5' | |||
| PendingAnalysisWaitTimeoutMinutes: '5' | |||
There was a problem hiding this comment.
I guess we can tune this out for network hiccups.
There was a problem hiding this comment.
Yeah I just grabbed the default of what using the AzDO UI fills in for this parameter.
hoyosjs
approved these changes
Sep 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the macos signing steps to use the same sigining tool version as the Windows signing steps.
Upgrade code signing task version to get a version that uses .NET 6.0 across the board.
Official build at: https://dev.azure.com/dnceng/internal/_build/results?buildId=2273647&view=results