-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IDispatch
should accept HRESULT
as valuetype
#92447
IDispatch
should accept HRESULT
as valuetype
#92447
Conversation
This is a regression from .NET Framework. The current behavior has existed since IDispatch was introduced into .NET Core. Added tests for the current behavior.
/cc @dotnet/interop-contrib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jkotas I don't see any obvious concern with this change, do you have any historical insight that I could be missing? The |
I do not have any obvious concerns either. |
/backport to release/8.0 |
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6277821403 |
This is a regression from .NET Framework.
The current behavior has existed since
IDispatch
was introduced into .NET Core.Added tests for the current behavior.