IDispatch should accept HRESULT as valuetype#92447
Merged
AaronRobinsonMSFT merged 4 commits intodotnet:mainfrom Sep 22, 2023
Merged
IDispatch should accept HRESULT as valuetype#92447AaronRobinsonMSFT merged 4 commits intodotnet:mainfrom
IDispatch should accept HRESULT as valuetype#92447AaronRobinsonMSFT merged 4 commits intodotnet:mainfrom
Conversation
This is a regression from .NET Framework. The current behavior has existed since IDispatch was introduced into .NET Core. Added tests for the current behavior.
Member
Author
|
/cc @dotnet/interop-contrib |
This was referenced Sep 22, 2023
Member
Author
|
@jkotas I don't see any obvious concern with this change, do you have any historical insight that I could be missing? The |
elinor-fung
reviewed
Sep 22, 2023
elinor-fung
approved these changes
Sep 22, 2023
Member
I do not have any obvious concerns either. |
Member
Author
|
/backport to release/8.0 |
Contributor
|
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6277821403 |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a regression from .NET Framework.
The current behavior has existed since
IDispatchwas introduced into .NET Core.Added tests for the current behavior.