Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0-rc1] [release/8.0] Events for IL methods without IL headers #92317

Merged
merged 6 commits into from
Sep 20, 2023

Conversation

github-actions[bot]
Copy link
Contributor

Backport of #90844 to release/8.0-rc1

/cc @mmitche @github-actions[bot]

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Dynamically generated methods like UnsafeAccessor
functions are marked as IL, but don't contain an IL
header. The lack of header is an indication the IL must
be generated at runtime.
Co-authored-by: Tlakaelel Axayakatl Ceja <tlakaelel.ceja@microsoft.com>
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@carlossanlop
Copy link
Member

@mmitche this is targeting rc1 instead of rc2.

@jeffschwMSFT
Copy link
Member

@mmitche this is targeting rc1 instead of rc2.

This is intentionally targeting RC1

@mmitche mmitche merged commit eafb0d6 into release/8.0-rc1 Sep 20, 2023
109 of 110 checks passed
@jkotas jkotas deleted the backport/pr-90844-to-release/8.0-rc1 branch September 21, 2023 17:18
@radical radical mentioned this pull request Sep 26, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Oct 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants