Skip to content

[QUIC] Throw ODE if connection/listener is disposed #92215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

ManickaP
Copy link
Member

AcceptConnection/StreamAsync now throws ODE in case the listener/connection was stopped by DisposeAsync.

Addresses the point 1. from #75115, which is the last remaining, unfixed concern.

Fixes #75115

@ghost
Copy link

ghost commented Sep 18, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

AcceptConnection/StreamAsync now throws ODE in case the listener/connection was stopped by DisposeAsync.

Addresses the point 1. from #75115, which is the last remaining, unfixed concern.

Fixes #75115

Author: ManickaP
Assignees: -
Labels:

area-System.Net.Quic

Milestone: -

Copy link
Member

@rzikm rzikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ManickaP
Copy link
Member Author

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ManickaP
Copy link
Member Author

Outerloop failures unrelated.

@ManickaP ManickaP merged commit 521e1e6 into dotnet:main Sep 20, 2023
@ManickaP ManickaP deleted the mapichov/quic-ode branch September 20, 2023 10:28
@karelz karelz added this to the 9.0.0 milestone Oct 11, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QuicListener.AcceptConnectionAsync rethrowing exceptions
4 participants