Skip to content

[main] Update dependencies from dotnet/roslyn #92150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Sep 19, 2023
Merged

[main] Update dependencies from dotnet/roslyn #92150

merged 14 commits into from
Sep 19, 2023

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Sep 15, 2023 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

  • Subscription: 037eb78c-9902-4cb9-856d-08db8ed7cafd
  • Build: 20230918.4
  • Date Produced: September 19, 2023 2:57:05 AM UTC
  • Commit: a19fe34b7266ab7638a12c2b54748d89d35a21a7
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20230…
9129bca 
…915.1

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23465.1
@ghost ghost added the area-codeflow for labeling automated codeflow label Sep 15, 2023
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20230…
5f858dc 
…915.2

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23465.2
@build-analysis build-analysis bot mentioned this pull request Sep 16, 2023
Closed
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20230…
2133937 
…915.4

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23465.4
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20230…
84da5d6 
…915.5

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23465.5
@build-analysis build-analysis bot mentioned this pull request Sep 16, 2023
Open
@carlossanlop carlossanlop self-assigned this Sep 18, 2023
@carlossanlop
Copy link
Contributor

Needs the same fix described in the 8.0 deps flow PR. I'll take care of it:
#92149 (comment)

@carlossanlop carlossanlop added the blocked Issue/PR is blocked on something - see comments label Sep 18, 2023
ericstj
ericstj approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look correct to me. Thanks for picking this up, @carlossanlop!

@carlossanlop carlossanlop removed the blocked Issue/PR is blocked on something - see comments label Sep 18, 2023
@carlossanlop
Copy link
Contributor

The CI is failing with related test failures now:

    Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.Bind_T_BinderOptions [FAIL]
      Assert.False() Failure
      Expected: False
      Actual:   True
      Stack Trace:
        /_/src/libraries/Microsoft.Extensions.Configuration.Binder/tests/SourceGenerationTests/GeneratorTests.Helpers.cs(152,0): at Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.RunGenerator(String testSourceCode, Boolean validateOutputCompDiags, LanguageVersion langVersion, IEnumerable`1 references)
        /_/src/libraries/Microsoft.Extensions.Configuration.Binder/tests/SourceGenerationTests/GeneratorTests.Helpers.cs(102,0): at Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.VerifyAgainstBaselineUsingFile(String filename, String testSourceCode, Action`1 assessDiagnostics, ExtensionClassType extType, Boolean validateOutputCompDiags)
        /_/src/libraries/Microsoft.Extensions.Configuration.Binder/tests/SourceGenerationTests/GeneratorTests.Baselines.Options.cs(99,0): at Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.Bind_T_BinderOptions()
        --- End of stack trace from previous location ---
    Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.Bind_Instance_BinderOptions [FAIL]
      Assert.False() Failure
      Expected: False
      Actual:   True
      Stack Trace:
        /_/src/libraries/Microsoft.Extensions.Configuration.Binder/tests/SourceGenerationTests/GeneratorTests.Helpers.cs(152,0): at Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.RunGenerator(String testSourceCode, Boolean validateOutputCompDiags, LanguageVersion langVersion, IEnumerable`1 references)
        /_/src/libraries/Microsoft.Extensions.Configuration.Binder/tests/SourceGenerationTests/GeneratorTests.Helpers.cs(102,0): at Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.VerifyAgainstBaselineUsingFile(String filename, String testSourceCode, Action`1 assessDiagnostics, ExtensionClassType extType, Boolean validateOutputCompDiags)
        /_/src/libraries/Microsoft.Extensions.Configuration.Binder/tests/SourceGenerationTests/GeneratorTests.Baselines.cs(83,0): at Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.Bind_Instance_BinderOptions()
        --- End of stack trace from previous location ---
      Assert.False() Failure
      Expected: False
      Actual:   True
    Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.BindConfiguration [FAIL]
      Stack Trace:
        /_/src/libraries/Microsoft.Extensions.Configuration.Binder/tests/SourceGenerationTests/GeneratorTests.Helpers.cs(152,0): at Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.RunGenerator(String testSourceCode, Boolean validateOutputCompDiags, LanguageVersion langVersion, IEnumerable`1 references)
        /_/src/libraries/Microsoft.Extensions.Configuration.Binder/tests/SourceGenerationTests/GeneratorTests.Helpers.cs(102,0): at Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.VerifyAgainstBaselineUsingFile(String filename, String testSourceCode, Action`1 assessDiagnostics, ExtensionClassType extType, Boolean validateOutputCompDiags)
        /_/src/libraries/Microsoft.Extensions.Configuration.Binder/tests/SourceGenerationTests/GeneratorTests.Baselines.Options.cs(129,0): at Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.BindConfiguration()
        --- End of stack trace from previous location ---
    Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.Get_T_BinderOptions [FAIL]
      Assert.False() Failure
      Expected: False
      Actual:   True
      Stack Trace:
        /_/src/libraries/Microsoft.Extensions.Configuration.Binder/tests/SourceGenerationTests/GeneratorTests.Helpers.cs(152,0): at Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.RunGenerator(String testSourceCode, Boolean validateOutputCompDiags, LanguageVersion langVersion, IEnumerable`1 references)
        /_/src/libraries/Microsoft.Extensions.Configuration.Binder/tests/SourceGenerationTests/GeneratorTests.Helpers.cs(102,0): at Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.VerifyAgainstBaselineUsingFile(String filename, String testSourceCode, Action`1 assessDiagnostics, ExtensionClassType extType, Boolean validateOutputCompDiags)
        /_/src/libraries/Microsoft.Extensions.Configuration.Binder/tests/SourceGenerationTests/GeneratorTests.Baselines.cs(300,0): at Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.Get_T_BinderOptions()
        --- End of stack trace from previous location ---
    Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.Bind_Instance [FAIL]
      Assert.False() Failure
      Expected: False
      Actual:   True
      Stack Trace:
        /_/src/libraries/Microsoft.Extensions.Configuration.Binder/tests/SourceGenerationTests/GeneratorTests.Helpers.cs(152,0): at Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.RunGenerator(String testSourceCode, Boolean validateOutputCompDiags, LanguageVersion langVersion, IEnumerable`1 references)
        /_/src/libraries/Microsoft.Extensions.Configuration.Binder/tests/SourceGenerationTests/GeneratorTests.Helpers.cs(102,0): at Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.VerifyAgainstBaselineUsingFile(String filename, String testSourceCode, Action`1 assessDiagnostics, ExtensionClassType extType, Boolean validateOutputCompDiags)
        /_/src/libraries/Microsoft.Extensions.Configuration.Binder/tests/SourceGenerationTests/GeneratorTests.Baselines.cs(49,0): at Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.Bind_Instance()
        --- End of stack trace from previous location ---
    Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.Get_T [FAIL]
      Assert.False() Failure
      Expected: False
      Actual:   True
      Stack Trace:
        /_/src/libraries/Microsoft.Extensions.Configuration.Binder/tests/SourceGenerationTests/GeneratorTests.Helpers.cs(152,0): at Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.RunGenerator(String testSourceCode, Boolean validateOutputCompDiags, LanguageVersion langVersion, IEnumerable`1 references)
        /_/src/libraries/Microsoft.Extensions.Configuration.Binder/tests/SourceGenerationTests/GeneratorTests.Helpers.cs(102,0): at Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.VerifyAgainstBaselineUsingFile(String filename, String testSourceCode, Action`1 assessDiagnostics, ExtensionClassType extType, Boolean validateOutputCompDiags)
        /_/src/libraries/Microsoft.Extensions.Configuration.Binder/tests/SourceGenerationTests/GeneratorTests.Baselines.cs(254,0): at Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.Get_T()
        --- End of stack trace from previous location ---

@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20230…
beb3824 
…918.1

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23468.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20230…
0de5fe9 
…918.1

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23468.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20230…
1049821 
…918.1

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23468.1
@carlossanlop carlossanlop mentioned this pull request Sep 18, 2023
Closed
carlossanlop
carlossanlop reviewed Sep 18, 2023
View reviewed changes
carlossanlop and others added 6 commits September 18, 2023 15:41
@carlossanlop
Bring back removed lines
52772d9
@carlossanlop
Add CSharpParseOption InterceptorsPreviewNamespaces feature to Genera…
b9d9ecc 
…torTests.Helpers.cs
@carlossanlop
Merge branch 'darc-main-77e82062-0d4d-42c2-b30b-45ed46b87d87' of http…
4532aa8 
…s://github.com/dotnet/runtime into darc-main-77e82062-0d4d-42c2-b30b-45ed46b87d87
@carlossanlop
Add TODO comment to remove feature
6013e07
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20230…
b95fdc9 
…918.3

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23468.3
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20230…
c2ab12e 
…918.4

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23468.4
@carlossanlop
Copy link
Contributor

CI is green for main. The CI failure in Microsoft.Extensions.Configuration.Binder only happens in release/8.0. Merging this now.

@carlossanlop carlossanlop merged commit 0eb038e into main Sep 19, 2023
@carlossanlop carlossanlop deleted the darc-main-77e82062-0d4d-42c2-b30b-45ed46b87d87 branch September 19, 2023 15:42
@ghost ghost locked as resolved and limited conversation to collaborators Oct 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carlossanlop carlossanlop carlossanlop left review comments

@ericstj ericstj ericstj approved these changes

Assignees

@carlossanlop carlossanlop

Labels
area-codeflow for labeling automated codeflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carlossanlop @ericstj