Skip to content

[wasi] Fix WasmLinkIcalls and WasmNativeStrip support. #91843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 16, 2023
Merged

[wasi] Fix WasmLinkIcalls and WasmNativeStrip support. #91843

merged 6 commits into from
Nov 16, 2023

Conversation

vargaz
Copy link
Contributor

@vargaz vargaz commented Sep 9, 2023

No description provided.

@vargaz vargaz requested a review from marek-safar as a code owner September 9, 2023 19:02
@ghost ghost added the area-Build-mono label Sep 9, 2023
@ghost ghost assigned vargaz Sep 9, 2023
@vargaz vargaz requested a review from radical September 9, 2023 19:02
@vargaz
Copy link
Contributor Author

vargaz commented Sep 9, 2023

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

campersau
campersau reviewed Sep 9, 2023
View reviewed changes
@vargaz
Copy link
Contributor Author

vargaz commented Sep 9, 2023

Looks like the aot compiler is not included in the wasi runtime pack.

This was referenced Sep 9, 2023
Closed
Closed
Closed
@lewing
Copy link
Member

lewing commented Sep 11, 2023

I thought AOT didn't currently work on wasi due to the inability to rely on runtime features?

@vargaz
Copy link
Contributor Author

vargaz commented Sep 11, 2023

The WasmLinkIcalls task relies on it to generate the icall table in the runtime.

@vargaz vargaz requested a review from lewing as a code owner September 12, 2023 00:57
@vargaz
Copy link
Contributor Author

vargaz commented Sep 12, 2023

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vargaz
Copy link
Contributor Author

vargaz commented Sep 12, 2023

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vargaz
Copy link
Contributor Author

vargaz commented Sep 12, 2023

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vargaz
Copy link
Contributor Author

vargaz commented Sep 14, 2023

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Sep 15, 2023
Closed
@vargaz
Copy link
Contributor Author

vargaz commented Sep 30, 2023

Depends on:
#92095

lewing
lewing approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@lewing lewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocked on #92095 but looks good once that lands

@lewing lewing added this to the 9.0.0 milestone Nov 15, 2023
@lewing lewing mentioned this pull request Nov 15, 2023
Open
10 tasks
@lewing lewing closed this Nov 16, 2023
@lewing lewing reopened this Nov 16, 2023
@lewing
Copy link
Member

lewing commented Nov 16, 2023

Build analysis is green

@lewing lewing merged commit 33d7f98 into dotnet:main Nov 16, 2023
@vargaz vargaz deleted the wasi-icalls branch November 16, 2023 04:02
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@campersau campersau campersau left review comments

@lewing lewing lewing approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar

@radical radical Awaiting requested review from radical

Assignees

@vargaz vargaz

Labels
area-Build-mono
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@vargaz @lewing @campersau