[release/8.0] Support assignment to multiple refs in trim analyzer #90936
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #90287 to release/8.0
/cc @sbomer
Customer Impact
Analyzer would throw an exception, producing the following error with certain specific code patterns involving assignments to multiple refs:
For example, the following code would produce this error:
Testing
Added testcases to validate that this and similar patterns no longer throw and produce reasonable analysis results (even though it is unlikely that such a pattern will be used in a way that is meaningful for the purpose of trim warnings).
Risk
Low risk. This fixes an analyzer crash without changing the analysis results for existing code. There's a fair amount of code in this change, but any risk is limited to the analyzer that runs during build, not directly affecting the runtime behavior or the output binary.